All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antoine Tenart <antoine.tenart@bootlin.com>
To: Stefan Chulski <stefanc@marvell.com>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
	Antoine Tenart <antoine.tenart@bootlin.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
	"maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
	"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
	"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
	Nadav Haklai <nadavh@marvell.com>,
	Yan Markman <ymarkman@marvell.com>,
	"mw@semihalf.com" <mw@semihalf.com>,
	Baruch Siach <baruch@tkos.co.il>
Subject: Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports
Date: Wed, 12 Dec 2018 10:32:13 +0100	[thread overview]
Message-ID: <20181212093213.GB3219@kwain> (raw)
In-Reply-To: <7b61c1fbf51a409684568216e799ebe3@IL-EXCH01.marvell.com>

Hi Stefan,

On Tue, Dec 11, 2018 at 09:11:31PM +0000, Stefan Chulski wrote:
> 
> > 
> > Are these modes supported on anything except port 0?  If not, you should be
> > rejecting these, rather than just treating them as RGMII.
> 
> In CP115(which has PPv2) PHY_INTERFACE_MODE_10GKR supported on ports 0 and 1
> PHY_INTERFACE_MODE_XAUI/PHY_INTERFACE_MODE_RXAUI supported only on port 0.

That's right. But I think we need to first fix this, and then when
adding support for the cp115 we'll rework this. We will need a way to
differentiate the CP110 PPv2 from the CP115 PPv2.

Thanks!
Antoine

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-12-12  9:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11 16:32 [PATCH net] net: mvpp2: 10G modes aren't supported on all ports Antoine Tenart
2018-12-11 16:36 ` Russell King - ARM Linux
2018-12-11 17:53   ` Baruch Siach
2018-12-11 18:51     ` Russell King - ARM Linux
2018-12-12  9:30       ` Antoine Tenart
2018-12-12 14:14         ` Antoine Tenart
2018-12-12 14:36           ` Baruch Siach
2018-12-11 21:11   ` Stefan Chulski
2018-12-12  9:32     ` Antoine Tenart [this message]
2018-12-18 22:49 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181212093213.GB3219@kwain \
    --to=antoine.tenart@bootlin.com \
    --cc=baruch@tkos.co.il \
    --cc=davem@davemloft.net \
    --cc=gregory.clement@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=stefanc@marvell.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=ymarkman@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.