All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Alice Ferrazzi <alice.ferrazzi@gmail.com>
Cc: ast@kernel.org, daniel@iogearbox.net, shuah@kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] selftest/bpf: test_offload PEP8 format style fix
Date: Wed, 12 Dec 2018 10:41:01 -0800	[thread overview]
Message-ID: <20181212103804.467945cc@cakuba.netronome.com> (raw)
In-Reply-To: <20181211115607.13774-5-alice.ferrazzi@gmail.com>

On Tue, 11 Dec 2018 20:56:04 +0900, Alice Ferrazzi wrote:
> Signed-off-by: Alice Ferrazzi <alice.ferrazzi@gmail.com>

Thanks, are you just running pylint to catch those?  I tried in the
past but it's very noisy and it lacked "understanding" of some python3
modules.  Would you mind giving us a quick 101 of how to catch such
errors? :)

> -def bpf_obj(name, sec=".text", path=bpf_test_dir,):
> +
> +def bpf_obj(name, sec=".text", path=bpf_test_dir, ):
>      return "obj %s sec %s" % (os.path.join(path, name), sec)
>  

I think this one is just a typo.  bpf_obj() seems to always get called
with one param, no?

  reply	other threads:[~2018-12-12 18:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11 11:56 [PATCH 0/7] selftest/bpf fix PEP8 warnings Alice Ferrazzi
2018-12-11 11:56 ` [PATCH 1/7] selftest/bpf: Fix trailing semicolon in the statement Alice Ferrazzi
2018-12-11 11:56 ` [PATCH 2/7] selftest/bpf: optimize import Alice Ferrazzi
2018-12-11 11:56 ` [PATCH 3/7] selftest/bpf: PEP 8: multiple statements on one line (colon) Alice Ferrazzi
2018-12-11 11:56 ` [PATCH 4/7] selftest/bpf: test_offload PEP8 format style fix Alice Ferrazzi
2018-12-12 18:41   ` Jakub Kicinski [this message]
2018-12-11 11:56 ` [PATCH 5/7] selftest/bpf: Fix PEP8 ambiguous variable name Alice Ferrazzi
2018-12-11 11:56 ` [PATCH 6/7] selftest/bpf: remove redundant parenthesis Alice Ferrazzi
2018-12-12 19:04   ` Jakub Kicinski
2018-12-12 21:15     ` Edward Cree
2018-12-13  0:25       ` Jakub Kicinski
2018-12-11 11:56 ` [PATCH 7/7] selftest/bpf: fix E501 line too long Alice Ferrazzi
2018-12-12 10:24   ` Daniel Borkmann
2018-12-12 19:06     ` Jakub Kicinski
2018-12-25  0:35   ` [selftest/bpf] b870be2f1b: kernel_selftests.bpf.test_offload.py.fail kernel test robot
2018-12-25  0:35     ` [LKP] " kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181212103804.467945cc@cakuba.netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=alice.ferrazzi@gmail.com \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.