From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data From: Greg Kroah-Hartman Message-Id: <20181212114024.GA26559@kroah.com> Date: Wed, 12 Dec 2018 12:40:24 +0100 To: Sebastian Andrzej Siewior Cc: "David S. Miller" , netdev@vger.kernel.org, linux-usb@vger.kernel.org, Hui Peng , Mathias Payer List-ID: T24gTW9uLCBEZWMgMTAsIDIwMTggYXQgMDE6NTA6MjBQTSArMDEwMCwgU2ViYXN0aWFuIEFuZHJ6 ZWogU2lld2lvciB3cm90ZToKPiBPbiAyMDE4LTEyLTEwIDA5OjA0OjQzIFsrMDEwMF0sIEdyZWcg S0ggd3JvdGU6Cj4gPiBGcm9tOiBIdWkgUGVuZyA8YmVucXVpa2VAZ21haWwuY29tPgo+ID4gCj4g PiBUaGUgZnVuY3Rpb24gaHNvX3Byb2JlIHJlYWRzIGlmX251bSBmcm9tIHRoZSBVU0IgZGV2aWNl IChhcyBhbiB1OCkgYW5kIHVzZXMKPiA+IGl0IHdpdGhvdXQgYSBsZW5ndGggY2hlY2sgdG8gaW5k ZXggYW4gYXJyYXksIHJlc3VsdGluZyBpbiBhbiBPT0IgbWVtb3J5IHJlYWQKPiA+IGluIGhzb19w cm9iZSBvciBoc29fZ2V0X2NvbmZpZ19kYXRhLiBBZGRlZCBhIGxlbmd0aCBjaGVjayBmb3IgYm90 aCBsb2NhdGlvbnMKPiA+IGFuZCB1cGRhdGVkIGhzb19wcm9iZSB0byBiYWlsIG9uIGVycm9yLgo+ IAo+IFRoZSBmdW5jdGlvbiBoc29fcHJvYmUgcmVhZHMgaWZfbnVtIGZyb20gdGhlIFVTQiBkZXZp Y2UgKGFzIGFuIHU4KSBhbmQgdXNlcwo+IGl0IHdpdGhvdXQgYSBsZW5ndGggY2hlY2sgdG8gaW5k ZXggYW4gYXJyYXksIHJlc3VsdGluZyBpbiBhbiBPT0IgbWVtb3J5IHJlYWQKPiBpbiBoc29fcHJv YmUgb3IgaHNvX2dldF9jb25maWdfZGF0YS4KPiAKPiBBZGQgYSBsZW5ndGggY2hlY2sgZm9yIGJv dGggbG9jYXRpb25zIGFuZCB1cGRhdGUgaHNvX3Byb2JlIHRvIGJhaWwgb24KPiBlcnJvci4KPiAK PiA+IFRoaXMgaXNzdWUgaGFzIGJlZW4gYXNzaWduZWQgQ1ZFLTIwMTgtMTk5ODUuCj4gPgo+ID4g UmVwb3J0ZWQtYnk6IEh1aSBQZW5nIDxiZW5xdWlrZUBnbWFpbC5jb20+Cj4gPiBSZXBvcnRlZC1i eTogTWF0aGlhcyBQYXllciA8bWF0aGlhcy5wYXllckBuZWJlbHdlbHQubmV0Pgo+ID4gU2lnbmVk LW9mZi1ieTogSHVpIFBlbmcgPGJlbnF1aWtlQGdtYWlsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6 IE1hdGhpYXMgUGF5ZXIgPG1hdGhpYXMucGF5ZXJAbmViZWx3ZWx0Lm5ldD4KPiA+IFNpZ25lZC1v ZmYtYnk6IEdyZWcgS3JvYWgtSGFydG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Cj4g Cj4gUmV2aWV3ZWQtYnk6IFNlYmFzdGlhbiBBbmRyemVqIFNpZXdpb3IgPGJpZ2Vhc3lAbGludXRy b25peC5kZT4KClRoYW5rcywgd2lsbCB1cGRhdGUgdGhlIGNoYW5nZWxvZyBhbmQgYWRkIHJlc2Vu ZC4KCmdyZWcgay1oCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data Date: Wed, 12 Dec 2018 12:40:24 +0100 Message-ID: <20181212114024.GA26559@kroah.com> References: <20181209163245.GA25484@kroah.com> <20181210080443.GA27035@kroah.com> <20181210125020.64nybfkrotjun7rw@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , netdev@vger.kernel.org, linux-usb@vger.kernel.org, Hui Peng , Mathias Payer To: Sebastian Andrzej Siewior Return-path: Received: from mail.kernel.org ([198.145.29.99]:53784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726869AbeLLLk1 (ORCPT ); Wed, 12 Dec 2018 06:40:27 -0500 Content-Disposition: inline In-Reply-To: <20181210125020.64nybfkrotjun7rw@linutronix.de> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Dec 10, 2018 at 01:50:20PM +0100, Sebastian Andrzej Siewior wrote: > On 2018-12-10 09:04:43 [+0100], Greg KH wrote: > > From: Hui Peng > > > > The function hso_probe reads if_num from the USB device (as an u8) and uses > > it without a length check to index an array, resulting in an OOB memory read > > in hso_probe or hso_get_config_data. Added a length check for both locations > > and updated hso_probe to bail on error. > > The function hso_probe reads if_num from the USB device (as an u8) and uses > it without a length check to index an array, resulting in an OOB memory read > in hso_probe or hso_get_config_data. > > Add a length check for both locations and update hso_probe to bail on > error. > > > This issue has been assigned CVE-2018-19985. > > > > Reported-by: Hui Peng > > Reported-by: Mathias Payer > > Signed-off-by: Hui Peng > > Signed-off-by: Mathias Payer > > Signed-off-by: Greg Kroah-Hartman > > Reviewed-by: Sebastian Andrzej Siewior Thanks, will update the changelog and add resend. greg k-h