From: P J P <ppandit@redhat.com>
To: Yuval Shaia <yuval.shaia@oracle.com>
Cc: Qemu Developers <qemu-devel@nongnu.org>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Saar Amar <saaramar5@gmail.com>, Li Qiang <liq3ea@163.com>,
Prasad J Pandit <pjp@fedoraproject.org>
Subject: [Qemu-devel] [PATCH v1 2/6] pvrdma: add uar_read routine
Date: Wed, 12 Dec 2018 17:17:22 +0530 [thread overview]
Message-ID: <20181212114726.24060-3-ppandit@redhat.com> (raw)
In-Reply-To: <20181212114726.24060-1-ppandit@redhat.com>
From: Prasad J Pandit <pjp@fedoraproject.org>
Define skeleton 'uar_read' routine. Avoid NULL dereference.
Reported-by: Li Qiang <liq3ea@163.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
hw/rdma/vmw/pvrdma_main.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
index 23dc9926e3..8a03ab4669 100644
--- a/hw/rdma/vmw/pvrdma_main.c
+++ b/hw/rdma/vmw/pvrdma_main.c
@@ -448,6 +448,11 @@ static const MemoryRegionOps regs_ops = {
},
};
+static uint64_t uar_read(void *opaque, hwaddr addr, unsigned size)
+{
+ return 0;
+}
+
static void uar_write(void *opaque, hwaddr addr, uint64_t val, unsigned size)
{
PVRDMADev *dev = opaque;
@@ -489,6 +494,7 @@ static void uar_write(void *opaque, hwaddr addr, uint64_t val, unsigned size)
}
static const MemoryRegionOps uar_ops = {
+ .read = uar_read,
.write = uar_write,
.endianness = DEVICE_LITTLE_ENDIAN,
.impl = {
--
2.19.2
next prev parent reply other threads:[~2018-12-12 11:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 11:47 [Qemu-devel] [PATCH v1 0/6] rdma: various issues in rdma/pvrdma backend P J P
2018-12-12 11:47 ` [Qemu-devel] [PATCH v1 1/6] rdma: check num_sge does not exceed MAX_SGE P J P
2018-12-12 16:56 ` Yuval Shaia
2018-12-12 11:47 ` P J P [this message]
2018-12-12 17:10 ` [Qemu-devel] [PATCH v1 2/6] pvrdma: add uar_read routine Marcel Apfelbaum
2018-12-12 11:47 ` [Qemu-devel] [PATCH v1 3/6] pvrdma: check number of pages when creating rings P J P
2018-12-12 17:06 ` Yuval Shaia
2018-12-12 11:47 ` [Qemu-devel] [PATCH v1 4/6] pvrdma: release ring object in case of an error P J P
2018-12-12 17:13 ` Yuval Shaia
2018-12-12 11:47 ` [Qemu-devel] [PATCH v1 5/6] pvrdma: check return value from pvrdma_idx_ring_has_ routines P J P
2018-12-12 18:55 ` Yuval Shaia
2018-12-12 11:47 ` [Qemu-devel] [PATCH v1 6/6] rdma: remove unused VENDOR_ERR_NO_SGE macro P J P
2018-12-12 17:23 ` Yuval Shaia
2018-12-12 17:26 ` Yuval Shaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212114726.24060-3-ppandit@redhat.com \
--to=ppandit@redhat.com \
--cc=liq3ea@163.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pjp@fedoraproject.org \
--cc=qemu-devel@nongnu.org \
--cc=saaramar5@gmail.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.