All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eyal Birger <eyal.birger@gmail.com>
To: Syrone Wong <wong.syrone@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute2-next] tc: fix xtables incorrect usage of LDFLAGS
Date: Wed, 12 Dec 2018 14:01:22 +0200	[thread overview]
Message-ID: <20181212140122.32bf401c@jimi> (raw)
In-Reply-To: <20181212113508.5089-1-wong.syrone@gmail.com>

On Wed, 12 Dec 2018 19:35:08 +0800
Syrone Wong <wong.syrone@gmail.com> wrote:

> The incorrect setting of LDFLAGS causes error below:
> 
> > em_ipt.o: In function `em_ipt_print_epot':
> > em_ipt.c:(.text.em_ipt_print_epot+0x2e): undefined reference to
> > `xtables_init_all'  
> 
> em_ipt.c gets involved when TC_CONFIG_XT=y, which requires xtables,
> while tc/Makefile doesn't pass flags correctly. It adds '-lxtables'
> to LDFLAGS instead of LDLIBS.
> 
> Fixes: dd296215 ("tc: add em_ipt ematch for calling xtables matches
> from tc matching context")
> 
> Signed-off-by: Syrone Wong <wong.syrone@gmail.com>

Thanks!

So iiuc there's some other LDFLAG coming after -lxtables on some
platform? sorry about that..

You can add my:

Acked-by: Eyal Birger <eyal.birger@gmail.com>

Eyal.

  reply	other threads:[~2018-12-12 12:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 11:35 [iproute2-next] tc: fix xtables incorrect usage of LDFLAGS Syrone Wong
2018-12-12 12:01 ` Eyal Birger [this message]
2018-12-12 12:04   ` Syrone Wong
2018-12-13 21:15     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181212140122.32bf401c@jimi \
    --to=eyal.birger@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=wong.syrone@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.