From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC5A9C67839 for ; Wed, 12 Dec 2018 17:19:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 717AF2086D for ; Wed, 12 Dec 2018 17:19:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544635147; bh=ppSsWLSPQN9/OSxzftYBE+M4YZMmUtfNScoa3kV4+T4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=xnlWeUYDM9CUGkFvLHYTQHscfHlKguVL8wXTYDc4LK7HOF0IBgR7TSn6bDutL5PCy B28aEU2Tn+cLt5tW0w+1zErrq7hztsFjOxUsQjpz6tP7xOui3Be9WPNK1yzGWRRe9B i4b8Mp9qgvXHAJBFtJVtAXB4v/4eFAg2hWwCjNVw= DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 717AF2086D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-iio-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727808AbeLLRTC (ORCPT ); Wed, 12 Dec 2018 12:19:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:35622 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726922AbeLLRTC (ORCPT ); Wed, 12 Dec 2018 12:19:02 -0500 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E3F8720851; Wed, 12 Dec 2018 17:18:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544635141; bh=ppSsWLSPQN9/OSxzftYBE+M4YZMmUtfNScoa3kV4+T4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uxTrmvkaTB7c7MIxVIMlAiOSjODDOxNeclC3tKq6YfVrs0v/llFmDmMftzwcid4ol xXOfdpZL+q0hgAElKsFcq/5bWo/quUlO0tYjQNKzLgtvHDBJrJTZul6FqGvGi79XSp lKpBQKsNnH6JRVfNKkeeK1wLR0tOSlieFoUQR/lI= Date: Wed, 12 Dec 2018 17:18:46 +0000 From: Jonathan Cameron To: =?UTF-8?B?UGF3ZcWC?= Chmiel Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, kgene@kernel.org, krzk@kernel.org, xc-racer2@live.ca, broonie@kernel.org, arnaud.pouliquen@st.com, baolin.wang@linaro.org, smohanad@codeaurora.org, eugen.hristev@microchip.com, rdunlap@infradead.org, vilhelm.gray@gmail.com, freeman.liu@spreadtrum.com, marcus.folkesson@gmail.com, geert@linux-m68k.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] iio: adc: exynos-adc: Add S5PV210 variant Message-ID: <20181212171846.4f4675a7@archlinux> In-Reply-To: <20181207191136.5464-2-pawel.mikolaj.chmiel@gmail.com> References: <20181207191136.5464-1-pawel.mikolaj.chmiel@gmail.com> <20181207191136.5464-2-pawel.mikolaj.chmiel@gmail.com> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 7 Dec 2018 20:11:34 +0100 Pawe=C5=82 Chmiel wrote: > From: Jonathan Bakker >=20 > S5PV210's ADC variant is almost the same as v1 except that it has 10 > channels and doesn't require the pmu register >=20 > Signed-off-by: Jonathan Bakker > Signed-off-by: Pawe=C5=82 Chmiel Long enough I thing ;) Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/adc/exynos_adc.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) >=20 > diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c > index f10443f92e4c..fa2d2b5767f3 100644 > --- a/drivers/iio/adc/exynos_adc.c > +++ b/drivers/iio/adc/exynos_adc.c > @@ -115,6 +115,7 @@ > #define MAX_ADC_V2_CHANNELS 10 > #define MAX_ADC_V1_CHANNELS 8 > #define MAX_EXYNOS3250_ADC_CHANNELS 2 > +#define MAX_S5PV210_ADC_CHANNELS 10 > =20 > /* Bit definitions common for ADC_V1 and ADC_V2 */ > #define ADC_CON_EN_START (1u << 0) > @@ -282,6 +283,16 @@ static const struct exynos_adc_data exynos_adc_v1_da= ta =3D { > .start_conv =3D exynos_adc_v1_start_conv, > }; > =20 > +static const struct exynos_adc_data exynos_adc_s5pv210_data =3D { > + .num_channels =3D MAX_S5PV210_ADC_CHANNELS, > + .mask =3D ADC_DATX_MASK, /* 12 bit ADC resolution */ > + > + .init_hw =3D exynos_adc_v1_init_hw, > + .exit_hw =3D exynos_adc_v1_exit_hw, > + .clear_irq =3D exynos_adc_v1_clear_irq, > + .start_conv =3D exynos_adc_v1_start_conv, > +}; > + > static void exynos_adc_s3c2416_start_conv(struct exynos_adc *info, > unsigned long addr) > { > @@ -478,6 +489,9 @@ static const struct of_device_id exynos_adc_match[] = =3D { > }, { > .compatible =3D "samsung,s3c6410-adc", > .data =3D &exynos_adc_s3c64xx_data, > + }, { > + .compatible =3D "samsung,s5pv210-adc", > + .data =3D &exynos_adc_s5pv210_data, > }, { > .compatible =3D "samsung,exynos-adc-v1", > .data =3D &exynos_adc_v1_data, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF627C65BAF for ; Wed, 12 Dec 2018 17:19:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A06FE20851 for ; Wed, 12 Dec 2018 17:19:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CrHlEvO/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="uxTrmvka" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A06FE20851 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qRI9yYz/r7n6aSKx67dAmb1nbai3LbkcU2c7wb8VEag=; b=CrHlEvO/NyZClO bcLhMbfExBkGaFkOoypztgDZNSYf15rxmXJQcQRAX9CyqpqPVEEwyi+l58+Fl/o6BiN5b/Gfbiy/f n1P9xOMEAq3QU7EBCTgApTXZ1U3t1J20jCu33/z64YCpFutwmLFfgB89eCw1+oWGaoKdel8DQA9o0 qklE9hHW+zjv5fqvaUltKBR/7UeuxrIGA0FFSaMY3E36U49hdxY6FAB+c+7jolpuNYsL36KxabH/Q sdLSZRtNtU/tbHvsJ+VT4KWW1I0cJTgSAT9VxfkhvzIlfeEscnpqaQpqjVke74uEYYbIyhqwqhIRG V1AsLkeumgeZncdzJkmg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gX8AF-0003hL-Pg; Wed, 12 Dec 2018 17:19:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gX8AC-0003e3-5G for linux-arm-kernel@lists.infradead.org; Wed, 12 Dec 2018 17:19:13 +0000 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E3F8720851; Wed, 12 Dec 2018 17:18:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544635141; bh=ppSsWLSPQN9/OSxzftYBE+M4YZMmUtfNScoa3kV4+T4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uxTrmvkaTB7c7MIxVIMlAiOSjODDOxNeclC3tKq6YfVrs0v/llFmDmMftzwcid4ol xXOfdpZL+q0hgAElKsFcq/5bWo/quUlO0tYjQNKzLgtvHDBJrJTZul6FqGvGi79XSp lKpBQKsNnH6JRVfNKkeeK1wLR0tOSlieFoUQR/lI= Date: Wed, 12 Dec 2018 17:18:46 +0000 From: Jonathan Cameron To: =?UTF-8?B?UGF3ZcWC?= Chmiel Subject: Re: [PATCH 1/3] iio: adc: exynos-adc: Add S5PV210 variant Message-ID: <20181212171846.4f4675a7@archlinux> In-Reply-To: <20181207191136.5464-2-pawel.mikolaj.chmiel@gmail.com> References: <20181207191136.5464-1-pawel.mikolaj.chmiel@gmail.com> <20181207191136.5464-2-pawel.mikolaj.chmiel@gmail.com> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181212_091912_228514_056F5012 X-CRM114-Status: GOOD ( 14.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, linux-iio@vger.kernel.org, xc-racer2@live.ca, pmeerw@pmeerw.net, freeman.liu@spreadtrum.com, marcus.folkesson@gmail.com, lars@metafoo.de, krzk@kernel.org, linux-samsung-soc@vger.kernel.org, kgene@kernel.org, geert@linux-m68k.org, devicetree@vger.kernel.org, smohanad@codeaurora.org, vilhelm.gray@gmail.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, baolin.wang@linaro.org, rdunlap@infradead.org, arnaud.pouliquen@st.com, linux-kernel@vger.kernel.org, broonie@kernel.org, knaack.h@gmx.de, eugen.hristev@microchip.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAgNyBEZWMgMjAxOCAyMDoxMTozNCArMDEwMApQYXdlxYIgQ2htaWVsIDxwYXdlbC5t aWtvbGFqLmNobWllbEBnbWFpbC5jb20+IHdyb3RlOgoKPiBGcm9tOiBKb25hdGhhbiBCYWtrZXIg PHhjLXJhY2VyMkBsaXZlLmNhPgo+IAo+IFM1UFYyMTAncyBBREMgdmFyaWFudCBpcyBhbG1vc3Qg dGhlIHNhbWUgYXMgdjEgZXhjZXB0IHRoYXQgaXQgaGFzIDEwCj4gY2hhbm5lbHMgYW5kIGRvZXNu J3QgcmVxdWlyZSB0aGUgcG11IHJlZ2lzdGVyCj4gCj4gU2lnbmVkLW9mZi1ieTogSm9uYXRoYW4g QmFra2VyIDx4Yy1yYWNlcjJAbGl2ZS5jYT4KPiBTaWduZWQtb2ZmLWJ5OiBQYXdlxYIgQ2htaWVs IDxwYXdlbC5taWtvbGFqLmNobWllbEBnbWFpbC5jb20+CkxvbmcgZW5vdWdoIEkgdGhpbmcgOykK CkFwcGxpZWQgdG8gdGhlIHRvZ3JlZyBicmFuY2ggb2YgaWlvLmdpdCBhbmQgcHVzaGVkIG91dCBh cyB0ZXN0aW5nCmZvciB0aGUgYXV0b2J1aWxkZXJzIHRvIHBsYXkgd2l0aCBpdC4KClRoYW5rcywK CkpvbmF0aGFuCgo+IC0tLQo+ICBkcml2ZXJzL2lpby9hZGMvZXh5bm9zX2FkYy5jIHwgMTQgKysr KysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKykKPiAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9paW8vYWRjL2V4eW5vc19hZGMuYyBiL2RyaXZlcnMvaWlvL2FkYy9l eHlub3NfYWRjLmMKPiBpbmRleCBmMTA0NDNmOTJlNGMuLmZhMmQyYjU3NjdmMyAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2lpby9hZGMvZXh5bm9zX2FkYy5jCj4gKysrIGIvZHJpdmVycy9paW8vYWRj L2V4eW5vc19hZGMuYwo+IEBAIC0xMTUsNiArMTE1LDcgQEAKPiAgI2RlZmluZSBNQVhfQURDX1Yy X0NIQU5ORUxTCQkxMAo+ICAjZGVmaW5lIE1BWF9BRENfVjFfQ0hBTk5FTFMJCTgKPiAgI2RlZmlu ZSBNQVhfRVhZTk9TMzI1MF9BRENfQ0hBTk5FTFMJMgo+ICsjZGVmaW5lIE1BWF9TNVBWMjEwX0FE Q19DSEFOTkVMUwkxMAo+ICAKPiAgLyogQml0IGRlZmluaXRpb25zIGNvbW1vbiBmb3IgQURDX1Yx IGFuZCBBRENfVjIgKi8KPiAgI2RlZmluZSBBRENfQ09OX0VOX1NUQVJUCSgxdSA8PCAwKQo+IEBA IC0yODIsNiArMjgzLDE2IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZXh5bm9zX2FkY19kYXRhIGV4 eW5vc19hZGNfdjFfZGF0YSA9IHsKPiAgCS5zdGFydF9jb252CT0gZXh5bm9zX2FkY192MV9zdGFy dF9jb252LAo+ICB9Owo+ICAKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBleHlub3NfYWRjX2RhdGEg ZXh5bm9zX2FkY19zNXB2MjEwX2RhdGEgPSB7Cj4gKwkubnVtX2NoYW5uZWxzCT0gTUFYX1M1UFYy MTBfQURDX0NIQU5ORUxTLAo+ICsJLm1hc2sJCT0gQURDX0RBVFhfTUFTSywJLyogMTIgYml0IEFE QyByZXNvbHV0aW9uICovCj4gKwo+ICsJLmluaXRfaHcJPSBleHlub3NfYWRjX3YxX2luaXRfaHcs Cj4gKwkuZXhpdF9odwk9IGV4eW5vc19hZGNfdjFfZXhpdF9odywKPiArCS5jbGVhcl9pcnEJPSBl eHlub3NfYWRjX3YxX2NsZWFyX2lycSwKPiArCS5zdGFydF9jb252CT0gZXh5bm9zX2FkY192MV9z dGFydF9jb252LAo+ICt9Owo+ICsKPiAgc3RhdGljIHZvaWQgZXh5bm9zX2FkY19zM2MyNDE2X3N0 YXJ0X2NvbnYoc3RydWN0IGV4eW5vc19hZGMgKmluZm8sCj4gIAkJCQkJICB1bnNpZ25lZCBsb25n IGFkZHIpCj4gIHsKPiBAQCAtNDc4LDYgKzQ4OSw5IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2Zf ZGV2aWNlX2lkIGV4eW5vc19hZGNfbWF0Y2hbXSA9IHsKPiAgCX0sIHsKPiAgCQkuY29tcGF0aWJs ZSA9ICJzYW1zdW5nLHMzYzY0MTAtYWRjIiwKPiAgCQkuZGF0YSA9ICZleHlub3NfYWRjX3MzYzY0 eHhfZGF0YSwKPiArCX0sIHsKPiArCQkuY29tcGF0aWJsZSA9ICJzYW1zdW5nLHM1cHYyMTAtYWRj IiwKPiArCQkuZGF0YSA9ICZleHlub3NfYWRjX3M1cHYyMTBfZGF0YSwKPiAgCX0sIHsKPiAgCQku Y29tcGF0aWJsZSA9ICJzYW1zdW5nLGV4eW5vcy1hZGMtdjEiLAo+ICAJCS5kYXRhID0gJmV4eW5v c19hZGNfdjFfZGF0YSwKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==