From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Alexander Steffen <Alexander.Steffen@infineon.com>
Cc: Tadeusz Struk <tadeusz.struk@intel.com>,
jgg@ziepe.ca, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm-dev: Require response to be read only if there actually is a response
Date: Wed, 12 Dec 2018 19:53:17 +0200 [thread overview]
Message-ID: <20181212175317.GA6333@linux.intel.com> (raw)
In-Reply-To: <20181206175801.23048-1-Alexander.Steffen@infineon.com>
On Thu, Dec 06, 2018 at 06:58:01PM +0100, Alexander Steffen wrote:
> If the tpm_transmit call in tpm_common_write fails for any reason, there is
> no response that could be read. Therefore, do not require the application
> to issue a read call before sending further commands. This restores the
> behavior from before support for partial reads was introduced.
>
> Signed-off-by: Alexander Steffen <Alexander.Steffen@infineon.com>
> ---
> Feel free to merge this into Tadeusz' original commit.
Thank you, good catch.
My PR is a bit late becuse just came from Oregon back to Finland so
I'll follow your advice and squash this. Thanks again.
/Jarkko
prev parent reply other threads:[~2018-12-12 17:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 17:58 [PATCH] tpm-dev: Require response to be read only if there actually is a response Alexander Steffen
2018-12-12 17:53 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212175317.GA6333@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Alexander.Steffen@infineon.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.