From: Peter Zijlstra <peterz@infradead.org>
To: Song Liu <songliubraving@fb.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
Kernel Team <Kernel-team@fb.com>,
"acme@kernel.org" <acme@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v3 perf, bpf-next 1/4] perf, bpf: Introduce PERF_RECORD_BPF_EVENT
Date: Wed, 12 Dec 2018 19:05:53 +0100 [thread overview]
Message-ID: <20181212180553.GC5289@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <C6E2C200-4C86-4EE0-97FA-228C0E0629B1@fb.com>
On Wed, Dec 12, 2018 at 05:09:17PM +0000, Song Liu wrote:
> > And while this tracks the bpf kallsyms, it does not do all kallsyms.
> >
> > .... Oooh, I see the problem, everybody is doing their own custom
> > kallsym_{add,del}() thing, instead of having that in generic code :-(
> >
> > This, for example, doesn't track module load/unload nor ftrace
> > trampolines, even though both affect kallsyms.
>
> I think we can use PERF_RECORD_MMAP(or MMAP2) for module load/unload.
> That could be separate sets of patches.
So I would actually like to move bpf_lock/bpf_kallsyms/bpf_tree +
bpf_prog_kallsyms_*() + __bpf_address_lookup() into kernel/kallsyms.c
and also have ftrace use that.
Because currently the ftrace stuff is otherwise invisible.
A generic kallsym register/unregister for any JIT.
next prev parent reply other threads:[~2018-12-12 18:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 23:33 [PATCH v3 perf, bpf-next 0/4] reveal invisible bpf programs Song Liu
2018-12-11 23:33 ` [PATCH v3 perf, bpf-next 1/4] perf, bpf: Introduce PERF_RECORD_BPF_EVENT Song Liu
2018-12-12 12:06 ` Peter Zijlstra
2018-12-12 16:49 ` Song Liu
2018-12-12 13:15 ` Peter Zijlstra
2018-12-12 13:27 ` Arnaldo Carvalho de Melo
2018-12-12 17:33 ` Song Liu
2018-12-12 17:09 ` Song Liu
2018-12-12 18:05 ` Peter Zijlstra [this message]
2018-12-12 18:33 ` Steven Rostedt
2018-12-12 18:58 ` Song Liu
2018-12-13 18:45 ` Peter Zijlstra
2018-12-13 21:48 ` Song Liu
2018-12-14 13:48 ` Arnaldo Carvalho de Melo
2018-12-14 17:10 ` Song Liu
2018-12-17 15:48 ` Peter Zijlstra
2018-12-12 18:56 ` Song Liu
2018-12-13 15:25 ` Peter Zijlstra
2018-12-13 16:07 ` Song Liu
2018-12-11 23:33 ` [PATCH v3 perf, bpf-next 2/4] perf: sync tools/include/uapi/linux/perf_event.h Song Liu
2018-12-11 23:33 ` [PATCH v3 perf, bpf-next 3/4] perf util: handle PERF_RECORD_BPF_EVENT Song Liu
2018-12-11 23:33 ` [PATCH v3 perf, bpf-next 4/4] perf tools: synthesize bpf event for loaded BPF programs Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212180553.GC5289@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Kernel-team@fb.com \
--cc=acme@kernel.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.