From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by arago-project.org (Postfix) with ESMTPS id DEEAC5297E for ; Wed, 12 Dec 2018 21:11:57 +0000 (UTC) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id wBCLBkOW026347 for ; Wed, 12 Dec 2018 15:11:46 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1544649106; bh=+sasxXAhKJza2iIcwUjDBn/D9di1Ggm2U96coU0vwiU=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=ZglUZ131i0UHLnZ6v5ow84Ao5D/KQEQMBS92oOepkpUWs8ITlHOSaqlG/DDsa0hK9 +acV/WmAGhlj21Mc7fgbA3MhL9w9o9pzYUznTa4CSpoFz4/7Ab1ssPEeLYsJdscKTV qDKjyGof03vvi6JpCzitQ/O/kZyqY/Yo8QFGREK4= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id wBCLBk4R026525 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 12 Dec 2018 15:11:46 -0600 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Wed, 12 Dec 2018 15:11:46 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Wed, 12 Dec 2018 15:11:46 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id wBCLBjkA010495; Wed, 12 Dec 2018 15:11:46 -0600 Date: Wed, 12 Dec 2018 16:11:45 -0500 From: Denys Dmytriyenko To: Jianzhong Xu Message-ID: <20181212211145.GC517@beryl> References: <1544565274-46138-1-git-send-email-xuj@ti.com> MIME-Version: 1.0 In-Reply-To: <1544565274-46138-1-git-send-email-xuj@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: meta-arago@arago-project.org Subject: Re: [rocko/master][PATCH v2] tidl-utils: add TIDL import tool source compilation. X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 21:11:58 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline So, you did remove the SUMMARY from .inc file. But you didn't address my comment about formatting issues with extra or missing spaces... Normally I don't complain about one or two of those in a patch - those are minor and as long as they don't break parsing or build, I accept them as is. But most open source projects and communities have coding styles, e.g. Linux kernel. And OpenEmbedded has it as well. When there are too many such coding style issues in a patch, I won't take it. Some examples, but the list is not complete: > +DEPENDS="protobuf zlib protobuf-native" > +BBCLASSEXTEND="native nativesdk" There should be exactly 1 space on each side of the = sign. > +SUMMARY = " TIDL import tool for conversion of Caffe and TF models into TI custom network format " There should not be spaces at the beginning and end of the text. > RDEPENDS_${PN}_class-target += " tidl-api tidl-examples " I know this was already in the recipe before your patch, but please also fix it - there's no need for spaces at the beginning and end of the list, when using += operand. -- Denys On Tue, Dec 11, 2018 at 04:54:34PM -0500, Jianzhong Xu wrote: > Signed-off-by: Jianzhong Xu > --- > .../nativesdk-packagegroup-arago-sdk-host.bb | 1 + > .../recipes-ti/tidl-utils/tidl-import_git.bb | 43 ++++++++++++++++++++++ > .../recipes-ti/tidl-utils/tidl-utils.bb | 7 ++-- > .../recipes-ti/tidl-utils/tidl-utils.inc | 2 + > 4 files changed, 49 insertions(+), 4 deletions(-) > create mode 100644 meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb > create mode 100644 meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc > > diff --git a/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb b/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb > index 54466b7..af83521 100644 > --- a/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb > +++ b/meta-arago-extras/recipes-core/packagegroups/nativesdk-packagegroup-arago-sdk-host.bb > @@ -13,6 +13,7 @@ EXTRA_TI_TOOLS = " \ > nativesdk-clacc \ > nativesdk-open62541-examples \ > nativesdk-open62541-tests \ > + nativesdk-tidl-import \ > " > > RDEPENDS_${PN} = "\ > diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb b/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb > new file mode 100644 > index 0000000..a644fbe > --- /dev/null > +++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb > @@ -0,0 +1,43 @@ > +SUMMARY = " TIDL import tool for conversion of Caffe and TF models into TI custom network format " > +DESCRIPTION = "TIDL import tool is using protobuf to read and parse information from external network models \ > + This is ARM Linux implementation." > + > +require ./tidl-utils.inc > + > +LICENSE = "BSD-3" > +LIC_FILES_CHKSUM = "file://modules/ti_dl/inc/itidl_ti.h;md5=7baa68fec0aadbac92c3b41b283d26c4" > + > +PV = "01.00.00.00" > +PR = "r1" > + > +S = "${WORKDIR}/git/src/importTool/" > + > +DEPENDS="protobuf zlib protobuf-native" > + > +EXTRA_OEMAKE += "TIARM_TOOLS=${GCC_ARM_NONE_TOOLCHAIN}" > +EXTRA_OEMAKE += "XDAIS_PATH=${XDAIS_INSTALL_DIR}" > +EXTRA_OEMAKE += "SHOW_COMMANDS=1" > +EXTRA_OEMAKE += "CORE=eve" > +EXTRA_OEMAKE += "TARGET_BUILD=release" > +EXTRA_OEMAKE += "TARGET_PLATFORM=PC" > + > +EXTRA_MAKE_ARGS = "PLATFORM_BUILD=x86 LINUX_IMPORT_TOOL=64BIT PROTOBUF_LIB_DIR=${STAGING_DIR_NATIVE}/usr/lib PROTOBUF_INC_DIR=${STAGING_DIR_NATIVE}/usr/include" > +EXTRA_MAKE_ARGS_class-target = "LINUX_BUILD_TOOLS=${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX} PROTOBUF_LIB_DIR=${STAGING_LIBDIR} PROTOBUF_INC_DIR=${STAGING_INCDIR} LINUXENV=oearm" > + > +EXTRA_OEMAKE += "${EXTRA_MAKE_ARGS}" > + > +do_compile() { > + cd ${S}/modules/ti_dl/utils > + ./genProtoSrc.sh > + cd ${S} > + oe_runmake -C modules/ti_dl/utils/tidlModelImport > +} > + > +do_install () { > + install -d ${D}${bindir} > + install -m 755 ${S}/modules/ti_dl/utils/tidlModelImport/out/tidl_model_import.out ${D}${bindir} > +} > + > +INSANE_SKIP_${PN} = "ldflags" > + > +BBCLASSEXTEND="native nativesdk" > diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb > index 569de5a..575a0a0 100644 > --- a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb > +++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb > @@ -3,16 +3,15 @@ DESCRIPTION = "TIDL Utilities for standalone simulation and importing / translat > HOMEPAGE = "http://software-dl.ti.com/processor-sdk-linux/esd/docs/latest/linux/Foundational_Components.html#tidl" > LICENSE = "TI-TFL" > > -PV = "1.0.0.0" > +require ./tidl-utils.inc > + > +PV = "1.0.0.1" > INC_PR = "r0" > > LIC_FILES_CHKSUM = "file://docs/LICENSE.txt;md5=a93aa5af7a3bbbb6fb34c8df59efaa5c" > > RDEPENDS_${PN}_class-target += " tidl-api tidl-examples " > > -SRC_URI = "git://git.ti.com/tidl/tidl-utils.git;protocol=git;branch=master" > -SRCREV = "994d90ae583610673d9d39086ca5e84027a9c56e" > - > PR = "${INC_PR}.0" > > S = "${WORKDIR}/git" > diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc > new file mode 100644 > index 0000000..37ce84d > --- /dev/null > +++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc > @@ -0,0 +1,2 @@ > +SRC_URI = "git://git.ti.com/tidl/tidl-utils.git;protocol=git;branch=master" > +SRCREV = "0021b6f15ee4a1a8919905429a5045fd02afe5b1" > -- > 1.9.1 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago