From: Sivaram Nair <sivaramn@nvidia.com>
To: Timo Alho <talho@nvidia.com>
Cc: treding@nvidia.com, linux-tegra@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/4] firmware: tegra: refactor bpmp driver
Date: Wed, 12 Dec 2018 13:26:50 -0800 [thread overview]
Message-ID: <20181212212650.GB3443@sdt> (raw)
In-Reply-To: <1544643088-17678-3-git-send-email-talho@nvidia.com>
On Wed, Dec 12, 2018 at 09:31:26PM +0200, Timo Alho wrote:
>
> static bool tegra_bpmp_is_req_ready(struct tegra_bpmp_channel *channel)
> {
> - return tegra_bpmp_is_resp_ready(channel);
> + struct tegra_bpmp *bpmp = channel->bpmp;
> +
> + return bpmp->soc->ops->is_req_ready(channel);
Perhaps, write a helper function to return ops pointer from channel and
use it here and below?
>
> +extern struct tegra_bpmp_ops tegra186_bpmp_ops;
Move this to bpmp-private.h?
next prev parent reply other threads:[~2018-12-12 21:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 19:31 [PATCH 0/4] add Tegra210 BPMP driver Timo Alho
2018-12-12 19:31 ` [PATCH 1/4] firmware: tegra: reword messaging terminology Timo Alho
2018-12-12 20:15 ` Sivaram Nair
2018-12-14 10:27 ` Timo Alho
2018-12-12 19:31 ` [PATCH 2/4] firmware: tegra: refactor bpmp driver Timo Alho
2018-12-12 21:26 ` Sivaram Nair [this message]
2018-12-12 19:31 ` [PATCH 3/4] firmware: tegra: add bpmp driver for Tegra210 Timo Alho
2018-12-12 21:31 ` Sivaram Nair
2018-12-12 19:31 ` [PATCH 4/4] dt-bindings: firmware: Add bindings for Tegra210 BPMP Timo Alho
2018-12-20 20:18 ` Rob Herring
2018-12-27 11:19 ` Timo Alho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212212650.GB3443@sdt \
--to=sivaramn@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=talho@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.