From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: [PATCH AUTOSEL 4.19 35/73] drm/msm: Fix error return checking Date: Wed, 12 Dec 2018 23:28:00 -0500 Message-ID: <20181213042838.75160-35-sashal@kernel.org> References: <20181213042838.75160-1-sashal@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181213042838.75160-1-sashal@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sasha Levin , David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Julia Lawall , Sean Paul , freedreno@lists.freedesktop.org, Wen Yang List-Id: linux-arm-msm@vger.kernel.org RnJvbTogV2VuIFlhbmcgPHdlbi55YW5nOTlAenRlLmNvbS5jbj4KClsgVXBzdHJlYW0gY29tbWl0 IDA5ODMzNmRlYjk0NmYzN2E3MGFmYzA5NzlhZjM4OGI2MTVjMzc4YmYgXQoKVGhlIGVycm9yIGNo ZWNrcyBvbiByZXQgZm9yIGEgbmVnYXRpdmUgZXJyb3IgcmV0dXJuIGFsd2F5cyBmYWlscyBiZWNh dXNlCnRoZSByZXR1cm4gdmFsdWUgb2YgaW9tbXVfbWFwX3NnKCkgaXMgdW5zaWduZWQgYW5kIGNh biBuZXZlciBiZSBuZWdhdGl2ZS4KCkRldGVjdGVkIHdpdGggQ29jY2luZWxsZToKZHJpdmVycy9n cHUvZHJtL21zbS9tc21faW9tbXUuYzo2OTo5LTEyOiBXQVJOSU5HOiBVbnNpZ25lZCBleHByZXNz aW9uCmNvbXBhcmVkIHdpdGggemVybzogcmV0IDwgMAoKU2lnbmVkLW9mZi1ieTogV2VuIFlhbmcg PHdlbi55YW5nOTlAenRlLmNvbS5jbj4KQ0M6IFJvYiBDbGFyayA8cm9iZGNsYXJrQGdtYWlsLmNv bT4KQ0M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KQ0M6IEp1bGlhIExhd2FsbCA8 anVsaWEubGF3YWxsQGxpcDYuZnI+CkNDOiBsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZwpD QzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpDQzogZnJlZWRyZW5vQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpDQzogbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZwpTaWduZWQtb2Zm LWJ5OiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9yZz4KU2lnbmVkLW9mZi1ieTogU2Fz aGEgTGV2aW4gPHNhc2hhbEBrZXJuZWwub3JnPgotLS0KIGRyaXZlcnMvZ3B1L2RybS9tc20vbXNt X2lvbW11LmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRp b24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9pb21tdS5jIGIvZHJp dmVycy9ncHUvZHJtL21zbS9tc21faW9tbXUuYwppbmRleCBiMjNkMzM2MjJmMzcuLjJhOTBhYTRj YWVjMCAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9tc21faW9tbXUuYworKysgYi9k cml2ZXJzL2dwdS9kcm0vbXNtL21zbV9pb21tdS5jCkBAIC02Niw3ICs2Niw3IEBAIHN0YXRpYyBp bnQgbXNtX2lvbW11X21hcChzdHJ1Y3QgbXNtX21tdSAqbW11LCB1aW50NjRfdCBpb3ZhLAogLy8J cG1fcnVudGltZV9nZXRfc3luYyhtbXUtPmRldik7CiAJcmV0ID0gaW9tbXVfbWFwX3NnKGlvbW11 LT5kb21haW4sIGlvdmEsIHNndC0+c2dsLCBzZ3QtPm5lbnRzLCBwcm90KTsKIC8vCXBtX3J1bnRp bWVfcHV0X3N5bmMobW11LT5kZXYpOwotCVdBUk5fT04ocmV0IDwgMCk7CisJV0FSTl9PTighcmV0 KTsKIAogCXJldHVybiAocmV0ID09IGxlbikgPyAwIDogLUVJTlZBTDsKIH0KLS0gCjIuMTkuMQoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E23EC65BAE for ; Thu, 13 Dec 2018 04:29:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8DE720882 for ; Thu, 13 Dec 2018 04:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544675391; bh=6TMEWmplXObtlXPfssWE6izb849ZoCBkmvEwN2jAZUQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=07iZfreMQhZAo1hjL3WJ/c0GwuPHIVeHq9/e36ywM2h9XHAq+IelQY9pUTYkPFPMO QXnE/Zs/TrRq82tuxRtt6pAgCIFzgNLAzzCqbnTUGYTeJsDPOmEhJ6pnkYxzlW/1aH EsyLcThp0isn9LStfKaPCzyusJgVtmHfeGWo9xR0= DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8DE720882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727868AbeLME3u (ORCPT ); Wed, 12 Dec 2018 23:29:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:42720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727834AbeLME3q (ORCPT ); Wed, 12 Dec 2018 23:29:46 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9AABE20873; Thu, 13 Dec 2018 04:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544675385; bh=6TMEWmplXObtlXPfssWE6izb849ZoCBkmvEwN2jAZUQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qQ1rRzBI8yAftk8dTquSPegADBOpX0d9lF7Vkft2Qqu7YXw7ucrsm5x6ZEoPZOqzH iGDi0Ngr0kcaqlXYKIWlygtF0o8MZnDXKYG4v/QgaSifCp8rDCVgIxA4ebjB1HSZAn KRwi5265YvkfpmrkwGhYvryDReTOBKcilE6hPM1E= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wen Yang , Rob Clark , David Airlie , Julia Lawall , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Sean Paul , Sasha Levin Subject: [PATCH AUTOSEL 4.19 35/73] drm/msm: Fix error return checking Date: Wed, 12 Dec 2018 23:28:00 -0500 Message-Id: <20181213042838.75160-35-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181213042838.75160-1-sashal@kernel.org> References: <20181213042838.75160-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wen Yang [ Upstream commit 098336deb946f37a70afc0979af388b615c378bf ] The error checks on ret for a negative error return always fails because the return value of iommu_map_sg() is unsigned and can never be negative. Detected with Coccinelle: drivers/gpu/drm/msm/msm_iommu.c:69:9-12: WARNING: Unsigned expression compared with zero: ret < 0 Signed-off-by: Wen Yang CC: Rob Clark CC: David Airlie CC: Julia Lawall CC: linux-arm-msm@vger.kernel.org CC: dri-devel@lists.freedesktop.org CC: freedreno@lists.freedesktop.org CC: linux-kernel@vger.kernel.org Signed-off-by: Sean Paul Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/msm_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gpu/drm/msm/msm_iommu.c index b23d33622f37..2a90aa4caec0 100644 --- a/drivers/gpu/drm/msm/msm_iommu.c +++ b/drivers/gpu/drm/msm/msm_iommu.c @@ -66,7 +66,7 @@ static int msm_iommu_map(struct msm_mmu *mmu, uint64_t iova, // pm_runtime_get_sync(mmu->dev); ret = iommu_map_sg(iommu->domain, iova, sgt->sgl, sgt->nents, prot); // pm_runtime_put_sync(mmu->dev); - WARN_ON(ret < 0); + WARN_ON(!ret); return (ret == len) ? 0 : -EINVAL; } -- 2.19.1