From: Yuval Shaia <yuval.shaia@oracle.com>
To: P J P <ppandit@redhat.com>
Cc: Qemu Developers <qemu-devel@nongnu.org>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Saar Amar <saaramar5@gmail.com>, Li Qiang <liq3ea@163.com>,
Prasad J Pandit <pjp@fedoraproject.org>,
yuval.shaia@oracle.com
Subject: Re: [Qemu-devel] [PATCH v2 5/6] rdma: remove unused VENDOR_ERR_NO_SGE macro
Date: Thu, 13 Dec 2018 07:19:55 +0200 [thread overview]
Message-ID: <20181213051954.GA2927@lap1> (raw)
In-Reply-To: <20181212193039.11445-6-ppandit@redhat.com>
On Thu, Dec 13, 2018 at 01:00:38AM +0530, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> With commit 4481985c (rdma: check num_sge does not exceed MAX_SGE)
> macro VENDOR_ERR_NO_SGE is no longer in use - delete it.
>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> ---
> hw/rdma/rdma_backend.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Update: change commit log message
> -> https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg02793.html
>
> diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
> index bd4710d16f..c28bfbd44d 100644
> --- a/hw/rdma/rdma_backend.c
> +++ b/hw/rdma/rdma_backend.c
> @@ -37,12 +37,11 @@
> #define VENDOR_ERR_TOO_MANY_SGES 0x202
> #define VENDOR_ERR_NOMEM 0x203
> #define VENDOR_ERR_QP0 0x204
> -#define VENDOR_ERR_NO_SGE 0x205
> +#define VENDOR_ERR_INV_NUM_SGE 0x205
> #define VENDOR_ERR_MAD_SEND 0x206
> #define VENDOR_ERR_INVLKEY 0x207
> #define VENDOR_ERR_MR_SMALL 0x208
> #define VENDOR_ERR_INV_MAD_BUFF 0x209
> -#define VENDOR_ERR_INV_NUM_SGE 0x210
>
> #define THR_NAME_LEN 16
> #define THR_POLL_TO 5000
Thanks.
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> --
> 2.19.2
>
next prev parent reply other threads:[~2018-12-13 5:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 19:30 [Qemu-devel] [PATCH v2 0/6] rdma: various issues in rdma/pvrdma backend P J P
2018-12-12 19:30 ` [Qemu-devel] [PATCH v2 1/6] rdma: check num_sge does not exceed MAX_SGE P J P
2018-12-12 19:30 ` [Qemu-devel] [PATCH v2 2/6] pvrdma: add uar_read routine P J P
2018-12-13 8:42 ` Marcel Apfelbaum
2018-12-12 19:30 ` [Qemu-devel] [PATCH v2 3/6] pvrdma: check number of pages when creating rings P J P
2018-12-16 20:30 ` Yuval Shaia
2018-12-17 18:47 ` P J P
2018-12-17 19:00 ` Yuval Shaia
2018-12-12 19:30 ` [Qemu-devel] [PATCH v2 4/6] pvrdma: release ring object in case of an error P J P
2018-12-12 19:30 ` [Qemu-devel] [PATCH v2 5/6] rdma: remove unused VENDOR_ERR_NO_SGE macro P J P
2018-12-13 5:19 ` Yuval Shaia [this message]
2018-12-12 19:30 ` [Qemu-devel] [PATCH v2 6/6] pvrdma: check return value from pvrdma_idx_ring_has_ routines P J P
2018-12-13 5:22 ` Yuval Shaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213051954.GA2927@lap1 \
--to=yuval.shaia@oracle.com \
--cc=liq3ea@163.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=saaramar5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.