diff for duplicates of <20181213083157.GD869@lst.de> diff --git a/a/1.txt b/N1/1.txt index c031a84..a72d32e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,16 +1,16 @@ -On Wed, Dec 12, 2018 at 10:38:18PM -0800, Sagi Grimberg wrote: +On Wed, Dec 12, 2018@10:38:18PM -0800, Sagi Grimberg wrote: > Since the multipath device does not support polling (yet) we cannot > pass requests to the polling queue map as those will not generate > interrupt so we cannot reap the completion. > -> Signed-off-by: Sagi Grimberg <sagi@grimberg.me> +> Signed-off-by: Sagi Grimberg <sagi at grimberg.me> As said before I don't think this is the right place. We need to handle the stacking case in the block layer. Something like this untested patch below should do the trick: -- -From b810e53e8a9ec6f62202c2ad65e6e56277bcace7 Mon Sep 17 00:00:00 2001 +>From b810e53e8a9ec6f62202c2ad65e6e56277bcace7 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig <hch@lst.de> Date: Thu, 13 Dec 2018 09:30:13 +0100 Subject: block: clear REQ_HIPRI if polling is not supported @@ -19,7 +19,7 @@ This prevents a HIPRI bio from being submitted through a stacking driver that does not support polling and thus won't poll for I/O completion. -Signed-off-by: Christoph Hellwig <hch@lst.de> +Signed-off-by: Christoph Hellwig <hch at lst.de> --- block/blk-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/a/content_digest b/N1/content_digest index f4af6fd..399104f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,30 +1,23 @@ "ref\020181213063819.13614-1-sagi@grimberg.me\0" "ref\020181213063819.13614-7-sagi@grimberg.me\0" - "From\0Christoph Hellwig <hch@lst.de>\0" - "Subject\0Re: [PATCH v2 6/6] nvme-multipath: disable polling for underlying namespace request queue\0" + "From\0hch@lst.de (Christoph Hellwig)\0" + "Subject\0[PATCH v2 6/6] nvme-multipath: disable polling for underlying namespace request queue\0" "Date\0Thu, 13 Dec 2018 09:31:57 +0100\0" - "To\0Sagi Grimberg <sagi@grimberg.me>\0" - "Cc\0linux-nvme@lists.infradead.org" - linux-block@vger.kernel.org - linux-rdma@vger.kernel.org - Christoph Hellwig <hch@lst.de> - Keith Busch <keith.busch@intel.com> - " Jens Axboe <axboe@kernel.dk>\0" "\00:1\0" "b\0" - "On Wed, Dec 12, 2018 at 10:38:18PM -0800, Sagi Grimberg wrote:\n" + "On Wed, Dec 12, 2018@10:38:18PM -0800, Sagi Grimberg wrote:\n" "> Since the multipath device does not support polling (yet) we cannot\n" "> pass requests to the polling queue map as those will not generate\n" "> interrupt so we cannot reap the completion.\n" "> \n" - "> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>\n" + "> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>\n" "\n" "As said before I don't think this is the right place. We need\n" "to handle the stacking case in the block layer. Something like this\n" "untested patch below should do the trick:\n" "\n" "--\n" - "From b810e53e8a9ec6f62202c2ad65e6e56277bcace7 Mon Sep 17 00:00:00 2001\n" + ">From b810e53e8a9ec6f62202c2ad65e6e56277bcace7 Mon Sep 17 00:00:00 2001\n" "From: Christoph Hellwig <hch@lst.de>\n" "Date: Thu, 13 Dec 2018 09:30:13 +0100\n" "Subject: block: clear REQ_HIPRI if polling is not supported\n" @@ -33,7 +26,7 @@ "driver that does not support polling and thus won't poll for I/O\n" "completion.\n" "\n" - "Signed-off-by: Christoph Hellwig <hch@lst.de>\n" + "Signed-off-by: Christoph Hellwig <hch at lst.de>\n" "---\n" " block/blk-core.c | 3 +++\n" " 1 file changed, 3 insertions(+)\n" @@ -55,4 +48,4 @@ "-- \n" 2.19.2 -25574928a3f69de35a50c83132e187467156f5e0cb77d8838dc7be99f5c794eb +bf8b94e369884090eed4ed4b5231a7419325af4590e55c3dc6d4b7e17e46de5a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.