From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: hverkuil@xs4all.nl, mchehab@kernel.org,
laurent.pinchart@ideasonboard.com
Subject: [PATCH 3/3] videobuf2-core.h: Document the alloc memop size argument as page aligned
Date: Thu, 13 Dec 2018 12:40:06 +0200 [thread overview]
Message-ID: <20181213104006.401-4-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20181213104006.401-1-sakari.ailus@linux.intel.com>
The size argument of the alloc memop, which allocates buffer memory, is
page aligned. Document it as such, as code elsewhere has not taken this
into account.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
include/media/videobuf2-core.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
index e86981d615ae4..68b9fe660e4f1 100644
--- a/include/media/videobuf2-core.h
+++ b/include/media/videobuf2-core.h
@@ -54,7 +54,8 @@ struct vb2_threadio_data;
* will then be passed as @buf_priv argument to other ops in this
* structure. Additional gfp_flags to use when allocating the
* are also passed to this operation. These flags are from the
- * gfp_flags field of vb2_queue.
+ * gfp_flags field of vb2_queue. The size argument to this function
+ * shall be *page aligned*.
* @put: inform the allocator that the buffer will no longer be used;
* usually will result in the allocator freeing the buffer (if
* no other users of this buffer are present); the @buf_priv
--
2.11.0
next prev parent reply other threads:[~2018-12-13 10:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 10:40 [PATCH 0/3] Videobuf2 corner case fixes Sakari Ailus
2018-12-13 10:40 ` [PATCH 1/3] videobuf2-core: Prevent size alignment wrapping buffer size to 0 Sakari Ailus
2018-12-13 11:22 ` Hans Verkuil
2018-12-13 12:49 ` Laurent Pinchart
2018-12-13 13:06 ` Sakari Ailus
2018-12-13 10:40 ` [PATCH 2/3] videobuf2-dma-sg: Prevent size from overflowing Sakari Ailus
2018-12-13 11:24 ` Hans Verkuil
2018-12-13 12:57 ` Laurent Pinchart
2018-12-13 13:00 ` Sakari Ailus
2018-12-13 13:03 ` Laurent Pinchart
2018-12-13 13:07 ` Sakari Ailus
2018-12-13 10:40 ` Sakari Ailus [this message]
2018-12-13 11:25 ` [PATCH 3/3] videobuf2-core.h: Document the alloc memop size argument as page aligned Hans Verkuil
2018-12-13 12:59 ` Laurent Pinchart
2018-12-13 13:02 ` Sakari Ailus
2018-12-13 13:08 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213104006.401-4-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.