All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Li Qiang" <liq3ea@gmail.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock}
Date: Thu, 13 Dec 2018 11:48:43 +0000	[thread overview]
Message-ID: <20181213114843.GE5171@redhat.com> (raw)
In-Reply-To: <CAFEAcA8tG-mXv63dDuJ-DFNDmxvv=AzK2rJXVFG5mnpPadGjGQ@mail.gmail.com>

On Thu, Dec 13, 2018 at 11:45:22AM +0000, Peter Maydell wrote:
> On Thu, 13 Dec 2018 at 11:37, Li Qiang <liq3ea@gmail.com> wrote:
> >
> > Also add diagnostics info in 'qemu_set_cloexec' so that we can know
> > what happen when error occurs.
> >
> > Signed-off-by: Li Qiang <liq3ea@gmail.com>
> > ---
> > Change since v1: add diagnostics info
> 
> We need to fix the assert in the test suite first...

Hopefully the improved diagnostics in this v2 will give us a better idea
of what the test suite failure is likely to be when patchew reports in....

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

  reply	other threads:[~2018-12-13 11:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13 11:37 [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock} Li Qiang
2018-12-13 11:45 ` Peter Maydell
2018-12-13 11:48   ` Daniel P. Berrangé [this message]
2018-12-13 11:49   ` Li Qiang
2018-12-13 12:38 ` Markus Armbruster
2018-12-13 16:01 ` no-reply
2018-12-14  1:46   ` Li Qiang
2018-12-14  9:15     ` Li Qiang
2018-12-14  9:49       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181213114843.GE5171@redhat.com \
    --to=berrange@redhat.com \
    --cc=liq3ea@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.