All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Jeff Cody <jcody@redhat.com>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
	John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block/mirror: add missing coroutine_fn annotations
Date: Thu, 13 Dec 2018 13:02:37 +0100	[thread overview]
Message-ID: <20181213120237.GB5427@linux.fritz.box> (raw)
In-Reply-To: <20181213112434.20039-1-stefanha@redhat.com>

Am 13.12.2018 um 12:24 hat Stefan Hajnoczi geschrieben:
> Marking a function coroutine_fn currently has no effect on the compiler,
> but it documents that this function must be called from coroutine
> context and it may yield.  This is important information for the
> programmer.
> 
> Also, if we ever transition to a stackless coroutine implementation,
> then it's likely that the annotation will become mandatory so the
> compiler can use the correct calling convention for coroutine functions.
> 
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: John Snow <jsnow@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Thanks, applied to the block branch.

Kevin

      reply	other threads:[~2018-12-13 12:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13 11:24 [Qemu-devel] [PATCH] block/mirror: add missing coroutine_fn annotations Stefan Hajnoczi
2018-12-13 12:02 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181213120237.GB5427@linux.fritz.box \
    --to=kwolf@redhat.com \
    --cc=jcody@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.