From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: Fix JEDEC detection
Date: Thu, 13 Dec 2018 12:03:02 +0100 [thread overview]
Message-ID: <20181213120302.425408f5@bbrezillon> (raw)
In-Reply-To: <20181213115701.06cee323@xps13>
On Thu, 13 Dec 2018 11:57:01 +0100
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Hi Boris,
>
> Boris Brezillon <boris.brezillon@bootlin.com> wrote on Thu, 13 Dec 2018
> 11:55:26 +0100:
>
> > nand_jedec_detect() should return 1 when the PARAM page parsing
> > succeeds, otherwise the core considers JEDEC detection failed and falls
> > back to ID-based detection.
> >
> > Fixes: 480139d9229e ("mtd: rawnand: get rid of the JEDEC parameter page in nand_chip")
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> > ---
> > drivers/mtd/nand/raw/nand_jedec.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mtd/nand/raw/nand_jedec.c b/drivers/mtd/nand/raw/nand_jedec.c
> > index 5c26492c841d..38b5dc22cb30 100644
> > --- a/drivers/mtd/nand/raw/nand_jedec.c
> > +++ b/drivers/mtd/nand/raw/nand_jedec.c
> > @@ -107,6 +107,8 @@ int nand_jedec_detect(struct nand_chip *chip)
> > pr_warn("Invalid codeword size\n");
> > }
> >
> > + ret = 1;
> > +
> > free_jedec_param_page:
> > kfree(p);
> > return ret;
>
> Sorry for the mistake.
>
> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Can you queue that one to nand/next?
next prev parent reply other threads:[~2018-12-13 11:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 10:55 [PATCH] mtd: rawnand: Fix JEDEC detection Boris Brezillon
2018-12-13 10:57 ` Miquel Raynal
2018-12-13 11:03 ` Boris Brezillon [this message]
2018-12-15 10:26 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213120302.425408f5@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.