From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 528FFC67839 for ; Thu, 13 Dec 2018 12:33:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1FFCD20849 for ; Thu, 13 Dec 2018 12:33:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FFCD20849 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-pci-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729134AbeLMMdW (ORCPT ); Thu, 13 Dec 2018 07:33:22 -0500 Received: from foss.arm.com ([217.140.101.70]:60858 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728517AbeLMMdW (ORCPT ); Thu, 13 Dec 2018 07:33:22 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 81326A78; Thu, 13 Dec 2018 04:33:21 -0800 (PST) Received: from red-moon (red-moon.cambridge.arm.com [10.1.197.39]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 298E23F575; Thu, 13 Dec 2018 04:33:20 -0800 (PST) Date: Thu, 13 Dec 2018 12:34:01 +0000 From: Lorenzo Pieralisi To: Lucas Stach Cc: Richard Zhu , "bhelgaas@google.com" , "andrew.smirnov@gmail.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [v2] PCI: imx: make msi work without pcieportbus Message-ID: <20181213123401.GA26763@red-moon> References: <1544687042-16595-1-git-send-email-hongxing.zhu@nxp.com> <1544692768.3137.25.camel@pengutronix.de> <1544695636.3137.27.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1544695636.3137.27.camel@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Dec 13, 2018 at 11:07:16AM +0100, Lucas Stach wrote: > Am Donnerstag, den 13.12.2018, 09:57 +0000 schrieb Richard Zhu: > > Hi Lucas: > > > > > -----Original Message----- > > > > > From: Lucas Stach [mailto:l.stach@pengutronix.de] > > > Sent: 2018年12月13日 17:19 > > > > > > > To: Richard Zhu ; bhelgaas@google.com; > > > lorenzo.pieralisi@arm.com; andrew.smirnov@gmail.com > > > > > > > Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > > linux-kernel@vger.kernel.org > > > Subject: Re: [v2] PCI: imx: make msi work without pcieportbus > > > > > > Hi Richard, > > > > > > Am Donnerstag, den 13.12.2018, 08:02 +0000 schrieb Richard Zhu: > > > > MSI_EN of iMX PCIe RC would be asserted when PCIEPORTBUS driver is > > > > selected. > > > > Thus, the MSI works fine on iMX PCIe before. > > > > Assert it unconditionally when MSI is supported. > > > > Otherwise, the MSI wouldn't be triggered although the EP is present > > > > and the MSIs are assigned. > > > > > > Thanks for digging into this issue. This seems like the right way forward. > > > However, did you test this with devices using legacy IRQs? > > > I.e. booting with "nomsi" on the kernel command line to see if legacy IRQs still > > > work if this bit is set, or if we need to avoid setting this when the user > > > explicitly requests to disable MSIs? > > > > > > Regards, > > > Lucas > > > > > > > [Richard Zhu] Thanks for your review. > > The Legacy INTx is broken. > > The MSI_EN bit shouldn't be asserted when the user explicitly requests to disable MSIs. > > Okay, so this patch should be extended with a check for > pci_msi_enabled() to see if the user explicitly want legacy IRQs. > > > BTW, regarding to Baruch's comments, it seems that all the (IS_ENABLED(CONFIG_PCI_MSI) check in > >  the dwc host drivers are not required anymore, since the depends on PCI_MSI_IRQ_DOMAIN, right? > > That's correct. This is mostly a historical artifact from the time when > we were able to build without MSI support. Those checks could be > cleaned up now that we depend on the MSI options. The question is whether we should really depend on PCI_MSI_IRQ_DOMAIN option, should we ? Lorenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B22FC65BAE for ; Thu, 13 Dec 2018 12:33:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F95F20645 for ; Thu, 13 Dec 2018 12:33:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XOjmwt+p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F95F20645 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jJegwyzfJ7wb8+jt3XUggmIg1eNiSbjoyaXHoQj/U9A=; b=XOjmwt+pssfBOk 5VBOUg6M++OOXx6IzyWdJHLgn9eUVlhoDcFOmzKYQJ58Jlx22VMBRRMbm9p2uNWJV7MwDp5V9nDUS j62DRlZKtl1eOqsyH80O8TBrMENG2gRCqncNbDc9bfo1tFi1ikCY8/yIn1PekYOHvgPkJ/B6TvmpC LFjlgFCnpQd92ZaP8Ux3si7GBh+pZy6kLJkRXo/MlvDivgJyt8A16qse8l9eTJP60dAsLIKQxu7cY 7d607nSC32ZnSiimD4ed+aSU0irM+DQTnryLO1IyiXVWBSIF9Z/Yn5cLwTaUvU+3DsUvmxB6s2JXa P46aVjOzgz5yB9SyWeSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gXQBP-0000kM-KK; Thu, 13 Dec 2018 12:33:39 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gXQBI-0000V0-5n for linux-arm-kernel@lists.infradead.org; Thu, 13 Dec 2018 12:33:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 81326A78; Thu, 13 Dec 2018 04:33:21 -0800 (PST) Received: from red-moon (red-moon.cambridge.arm.com [10.1.197.39]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 298E23F575; Thu, 13 Dec 2018 04:33:20 -0800 (PST) Date: Thu, 13 Dec 2018 12:34:01 +0000 From: Lorenzo Pieralisi To: Lucas Stach Subject: Re: [v2] PCI: imx: make msi work without pcieportbus Message-ID: <20181213123401.GA26763@red-moon> References: <1544687042-16595-1-git-send-email-hongxing.zhu@nxp.com> <1544692768.3137.25.camel@pengutronix.de> <1544695636.3137.27.camel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1544695636.3137.27.camel@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181213_043332_341514_60499DB8 X-CRM114-Status: GOOD ( 22.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Zhu , "andrew.smirnov@gmail.com" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBEZWMgMTMsIDIwMTggYXQgMTE6MDc6MTZBTSArMDEwMCwgTHVjYXMgU3RhY2ggd3Jv dGU6Cj4gQW0gRG9ubmVyc3RhZywgZGVuIDEzLjEyLjIwMTgsIDA5OjU3ICswMDAwIHNjaHJpZWIg UmljaGFyZCBaaHU6Cj4gPiBIaSBMdWNhczoKPiA+IAo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3Nh Z2UtLS0tLQo+ID4gPiA+ID4gRnJvbTogTHVjYXMgU3RhY2ggW21haWx0bzpsLnN0YWNoQHBlbmd1 dHJvbml4LmRlXQo+ID4gPiBTZW50OiAyMDE45bm0MTLmnIgxM+aXpSAxNzoxOQo+ID4gPiA+ID4g PiA+IFRvOiBSaWNoYXJkIFpodSA8aG9uZ3hpbmcuemh1QG54cC5jb20+OyBiaGVsZ2Fhc0Bnb29n bGUuY29tOwo+ID4gPiBsb3JlbnpvLnBpZXJhbGlzaUBhcm0uY29tOyBhbmRyZXcuc21pcm5vdkBn bWFpbC5jb20KPiA+ID4gPiA+ID4gPiBDYzogbGludXgtcGNpQHZnZXIua2VybmVsLm9yZzsgbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnOwo+ID4gPiBsaW51eC1rZXJuZWxAdmdl ci5rZXJuZWwub3JnCj4gPiA+IFN1YmplY3Q6IFJlOiBbdjJdIFBDSTogaW14OiBtYWtlIG1zaSB3 b3JrIHdpdGhvdXQgcGNpZXBvcnRidXMKPiA+ID4gCj4gPiA+IEhpIFJpY2hhcmQsCj4gPiA+IAo+ ID4gPiBBbSBEb25uZXJzdGFnLCBkZW4gMTMuMTIuMjAxOCwgMDg6MDIgKzAwMDAgc2NocmllYiBS aWNoYXJkIFpodToKPiA+ID4gPiBNU0lfRU4gb2YgaU1YIFBDSWUgUkMgd291bGQgYmUgYXNzZXJ0 ZWQgd2hlbiBQQ0lFUE9SVEJVUyBkcml2ZXIgaXMKPiA+ID4gPiBzZWxlY3RlZC4KPiA+ID4gPiBU aHVzLCB0aGUgTVNJIHdvcmtzIGZpbmUgb24gaU1YIFBDSWUgYmVmb3JlLgo+ID4gPiA+IEFzc2Vy dCBpdCB1bmNvbmRpdGlvbmFsbHkgd2hlbiBNU0kgaXMgc3VwcG9ydGVkLgo+ID4gPiA+IE90aGVy d2lzZSwgdGhlIE1TSSB3b3VsZG4ndCBiZSB0cmlnZ2VyZWQgYWx0aG91Z2ggdGhlIEVQIGlzIHBy ZXNlbnQKPiA+ID4gPiBhbmQgdGhlIE1TSXMgYXJlIGFzc2lnbmVkLgo+ID4gPiAKPiA+ID4gVGhh bmtzIGZvciBkaWdnaW5nIGludG8gdGhpcyBpc3N1ZS4gVGhpcyBzZWVtcyBsaWtlIHRoZSByaWdo dCB3YXkgZm9yd2FyZC4KPiA+ID4gSG93ZXZlciwgZGlkIHlvdSB0ZXN0IHRoaXMgd2l0aCBkZXZp Y2VzIHVzaW5nIGxlZ2FjeSBJUlFzPwo+ID4gPiBJLmUuIGJvb3Rpbmcgd2l0aCAibm9tc2kiIG9u IHRoZSBrZXJuZWwgY29tbWFuZCBsaW5lIHRvIHNlZSBpZiBsZWdhY3kgSVJRcyBzdGlsbAo+ID4g PiB3b3JrIGlmIHRoaXMgYml0IGlzIHNldCwgb3IgaWYgd2UgbmVlZCB0byBhdm9pZCBzZXR0aW5n IHRoaXMgd2hlbiB0aGUgdXNlcgo+ID4gPiBleHBsaWNpdGx5IHJlcXVlc3RzIHRvIGRpc2FibGUg TVNJcz8KPiA+ID4gCj4gPiA+IFJlZ2FyZHMsCj4gPiA+IEx1Y2FzCj4gPiA+IAo+ID4gCj4gPiBb UmljaGFyZCBaaHVdIFRoYW5rcyBmb3IgeW91ciByZXZpZXcuCj4gPiBUaGUgTGVnYWN5IElOVHgg aXMgYnJva2VuLgo+ID4gVGhlIE1TSV9FTiBiaXQgc2hvdWxkbid0IGJlIGFzc2VydGVkIHdoZW4g dGhlIHVzZXIgZXhwbGljaXRseSByZXF1ZXN0cyB0byBkaXNhYmxlIE1TSXMuCj4gCj4gT2theSwg c28gdGhpcyBwYXRjaCBzaG91bGQgYmUgZXh0ZW5kZWQgd2l0aCBhIGNoZWNrIGZvcgo+IHBjaV9t c2lfZW5hYmxlZCgpIHRvIHNlZSBpZiB0aGUgdXNlciBleHBsaWNpdGx5IHdhbnQgbGVnYWN5IElS UXMuCj4gCj4gPiBCVFcsIHJlZ2FyZGluZyB0byBCYXJ1Y2gncyBjb21tZW50cywgaXQgc2VlbXMg dGhhdCBhbGwgdGhlIChJU19FTkFCTEVEKENPTkZJR19QQ0lfTVNJKSBjaGVjayBpbgo+ID4gwqB0 aGUgZHdjIGhvc3QgZHJpdmVycyBhcmUgbm90IHJlcXVpcmVkIGFueW1vcmUsIHNpbmNlIHRoZSBk ZXBlbmRzIG9uIFBDSV9NU0lfSVJRX0RPTUFJTiwgcmlnaHQ/Cj4gCj4gVGhhdCdzIGNvcnJlY3Qu IFRoaXMgaXMgbW9zdGx5IGEgaGlzdG9yaWNhbCBhcnRpZmFjdCBmcm9tIHRoZSB0aW1lIHdoZW4K PiAgd2Ugd2VyZSBhYmxlIHRvIGJ1aWxkIHdpdGhvdXQgTVNJIHN1cHBvcnQuIFRob3NlIGNoZWNr cyBjb3VsZCBiZQo+IGNsZWFuZWQgdXAgbm93IHRoYXQgd2UgZGVwZW5kIG9uIHRoZSBNU0kgb3B0 aW9ucy4KClRoZSBxdWVzdGlvbiBpcyB3aGV0aGVyIHdlIHNob3VsZCByZWFsbHkgZGVwZW5kIG9u IFBDSV9NU0lfSVJRX0RPTUFJTgpvcHRpb24sIHNob3VsZCB3ZSA/CgpMb3JlbnpvCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==