From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
Johan Hovold <johan@kernel.org>,
Ladislav Michl <ladis@linux-mips.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: USB: ehci-omap: Fix deferred probe for phy handling
Date: Thu, 13 Dec 2018 06:34:19 -0800 [thread overview]
Message-ID: <20181213143419.GM39861@atomide.com> (raw)
* Roger Quadros <rogerq@ti.com> [181213 12:09]:
> Tony,
>
> On 13/12/18 04:17, Tony Lindgren wrote:
> > The only case where we can bail out safely without a phy is port_mode
> > is OMAP_USBHS_PORT_MODE_UNUSED. It used to be that OMAP_EHCI_PORT_MODE_PHY
> > was optional, but that's not a good assumption. We should already have
> > "ehci-phy" in all the dts files using OMAP_EHCI_PORT_MODE_PHY.
> >
>
> We don't use the PHY at all if port mode is not OMAP_EHCI_PORT_MODE_PHY.
Hmm thanks for looking. That logic seems like it was valid
something like 10 years ago for omap3, I don't think that applies
any longer.
We see -EPROBE_DEFER errors for OMAP_EHCI_PORT_MODE_HSIC on
omap5-uevm for SMSC Ethernet. So that's with "ehci-hsic" in the dts
files.
> What issue is this patch fixing?
We ignore -EPROBE_DEFER errors now. That's reproducable with
current Linux next on omap5-uevm with phy-generic, ehci-omap and
smsc Ethernet built-in. After boot ifconfig -a won't show eth0.
Care to recheck what the safe logic to ignore errors can be?
Regards,
Tony
next reply other threads:[~2018-12-13 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 14:34 Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-13 12:08 USB: ehci-omap: Fix deferred probe for phy handling Roger Quadros
2018-12-13 7:25 Peter Ujfalusi
2018-12-13 2:17 Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213143419.GM39861@atomide.com \
--to=tony@atomide.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=ladis@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=rogerq@ti.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.