From: Tony Lindgren <tony@atomide.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH][RFC] ASoC: simple-card-utils: fixup asoc_simple_card_get_dai_id() ID method
Date: Thu, 13 Dec 2018 08:42:06 -0800 [thread overview]
Message-ID: <20181213164206.GV39861@atomide.com> (raw)
In-Reply-To: <87va3y10a0.wl-kuninori.morimoto.gx@renesas.com>
* Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> [181213 05:18]:
> commit b6f3fc005a2c8 ("ASoC: simple-card-utils: fixup
> asoc_simple_card_get_dai_id() counting") fixuped getting DAI ID method.
> It will get DAI ID from OF graph "port", but, we want to consider about
> "endpoint", too.
> And, we also want to keep compatibility.
>
> This patch fixup it as
>
> if (driver has specified DAI ID)
> use it as DAI ID
> else if (OF graph endpoint has reg)
> use it as DAI ID
> else if (OF graph port has reg)
> use it as DAI ID
> else
> use endpoint count as DAI ID
Yup I tested this instead of the earlier 1/7 patch
and things work nice for me. I also commented out
reg properties from the codec end and the mapping
worked fine. So please feel free to add:
Tested-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2018-12-13 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 5:18 [PATCH][RFC] ASoC: simple-card-utils: fixup asoc_simple_card_get_dai_id() ID method Kuninori Morimoto
2018-12-13 16:42 ` Tony Lindgren [this message]
2018-12-14 0:16 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213164206.GV39861@atomide.com \
--to=tony@atomide.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.