From: Sasha Levin <sashal@kernel.org>
To: Dexuan Cui <decui@microsoft.com>
Cc: "'gregkh@linuxfoundation.org'" <gregkh@linuxfoundation.org>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'devel@linuxdriverproject.org'" <devel@linuxdriverproject.org>,
Sasha Levin <Alexander.Levin@microsoft.com>,
"'apw@canonical.com'" <apw@canonical.com>,
vkuznets <vkuznets@redhat.com>,
"'olaf@aepfle.de'" <olaf@aepfle.de>,
"'jasowang@redhat.com'" <jasowang@redhat.com>,
Michael Kelley <mikelley@microsoft.com>
Subject: Re: [PATCH] Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels
Date: Thu, 13 Dec 2018 14:59:23 -0500 [thread overview]
Message-ID: <20181213195923.GL2746@sasha-vm> (raw)
In-Reply-To: <PU1P153MB0169DDAA2CBC2901505AE692BFA00@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
On Thu, Dec 13, 2018 at 04:35:43PM +0000, Dexuan Cui wrote:
>
>Before 98f4c651762c, we returned zeros for unopened channels.
>With 98f4c651762c, we started to return random on-stack values.
>
>We'd better return -EINVAL instead.
>
>Fixes: 98f4c651762c ("hv: move ringbuffer bus attributes to dev_groups")
>Cc: stable@vger.kernel.org
>Cc: K. Y. Srinivasan <kys@microsoft.com>
>Cc: Haiyang Zhang <haiyangz@microsoft.com>
>Cc: Stephen Hemminger <sthemmin@microsoft.com>
>Signed-off-by: Dexuan Cui <decui@microsoft.com>
Queued up, thank you.
--
Thanks,
Sasha
next prev parent reply other threads:[~2018-12-13 19:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 16:35 [PATCH] Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels Dexuan Cui
2018-12-13 19:59 ` Sasha Levin [this message]
2018-12-17 17:15 ` Stephen Hemminger
2018-12-17 18:00 ` Dexuan Cui
2018-12-17 18:17 ` Stephen Hemminger
2018-12-17 18:31 ` Dexuan Cui
2018-12-17 18:44 ` Dexuan Cui
2018-12-17 20:35 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213195923.GL2746@sasha-vm \
--to=sashal@kernel.org \
--cc=Alexander.Levin@microsoft.com \
--cc=apw@canonical.com \
--cc=decui@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.