From: Eduardo Habkost <ehabkost@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Kashyap Chamarthy <kchamart@redhat.com>,
qemu-devel@nongnu.org, eblake@redhat.com, armbru@redhat.com,
imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/3] Update that HMP 'cpu_add' is deprecated in 4.0
Date: Thu, 13 Dec 2018 19:58:10 -0200 [thread overview]
Message-ID: <20181213215810.GD7141@habkost.net> (raw)
In-Reply-To: <2ce67a1c-caaf-cac1-1374-c09da3c4e472@redhat.com>
On Thu, Dec 13, 2018 at 09:03:23PM +0100, Thomas Huth wrote:
> On 2018-12-13 13:42, Kashyap Chamarthy wrote:
> > Also fix the wrong spelling of it: s/cpu-add/cpu_add/
> >
> > Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
> > ---
> > qemu-deprecated.texi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> > index 46bec688db..79743ab8bd 100644
> > --- a/qemu-deprecated.texi
> > +++ b/qemu-deprecated.texi
> > @@ -121,9 +121,9 @@ replaced by the ``target'' output member.
> > The @option{[hub_id name]} parameter tuple of the 'hostfwd_add' and
> > 'hostfwd_remove' HMP commands has been replaced by @option{netdev_id}.
> >
> > -@subsection cpu-add (since 3.1)
> > +@subsection cpu_add (since 4.0)
> >
> > -Use ``device_add'' for hotplugging vCPUs instead of ``cpu-add''. See
> > +Use ``device_add'' for hotplugging vCPUs instead of ``cpu_add''. See
>
> AFAIK the spelling was right. It's "cpu-add" ... only device_add is
> using the underscore. Welcome to the wonderful world of QEMU
> inconsistencies...
Thanks for noting. I have fixed it while committing.
--
Eduardo
next prev parent reply other threads:[~2018-12-13 21:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 12:42 [Qemu-devel] [PATCH 0/3] Update deprecation notes for QMP 'cpu-add' & HMP 'cpu_add' Kashyap Chamarthy
2018-12-13 12:42 ` [Qemu-devel] [PATCH 1/3] qemu-deprecated.texi: Rename the HMP section Kashyap Chamarthy
2018-12-13 20:01 ` Thomas Huth
2018-12-13 12:42 ` [Qemu-devel] [PATCH 2/3] Update that HMP 'cpu_add' is deprecated in 4.0 Kashyap Chamarthy
2018-12-13 14:51 ` Igor Mammedov
2018-12-13 20:03 ` Thomas Huth
2018-12-13 21:58 ` Eduardo Habkost [this message]
2018-12-14 12:16 ` Kashyap Chamarthy
2018-12-13 12:42 ` [Qemu-devel] [PATCH 3/3] Mention that QMP 'cpu-add' will be deprecated Kashyap Chamarthy
2018-12-13 14:52 ` Igor Mammedov
2018-12-13 20:04 ` Thomas Huth
2018-12-13 21:59 ` [Qemu-devel] [PATCH 0/3] Update deprecation notes for QMP 'cpu-add' & HMP 'cpu_add' Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213215810.GD7141@habkost.net \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=kchamart@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.