From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] xapp_beforelight: fix build with pkgconf 1.5.3
Date: Thu, 13 Dec 2018 22:19:32 +0100 [thread overview]
Message-ID: <20181213221932.422dbdcd@windsurf> (raw)
In-Reply-To: <20181213205952.29015-1-fontaine.fabrice@gmail.com>
Hello,
On Thu, 13 Dec 2018 21:59:52 +0100, Fabrice Fontaine wrote:
> Since the bump to 1.5.3, pkgconf prepends the sysroot to all absolute
> paths found in the .pc file. This is correct when the paths refer to
> something in STAGING_DIR (e.g. libdir, includedir), but not when it
> refers to something used for the target.
>
> xapp_beforelight uses the appdefaultdir variable from xt.pc to decide
> where to install things. Since DESTDIR is prepended to the install
> destination, this will end up in the wrong location.
>
> Until a better solution is found in pkgconf, pass the appdefaultdir to
> use explicitly instead of relying on xt.pc.
>
> Fixes:
> - http://autobuild.buildroot.org/results/164bb80f261f48525de508b5f74321f2fec91cce
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/x11r7/xapp_beforelight/xapp_beforelight.mk | 1 +
> 1 file changed, 1 insertion(+)
I have applied the entire series of xapp_* fixes. I find it a bit
annoying that we have to spread this workaround in so many places, but
OK we don't have a good alternative option for now.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-12-13 21:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 20:59 [Buildroot] [PATCH 1/1] xapp_beforelight: fix build with pkgconf 1.5.3 Fabrice Fontaine
2018-12-13 21:19 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213221932.422dbdcd@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.