From: Christoph Hellwig <hch@infradead.org>
To: Sebastian Ott <sebott@linux.ibm.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Russell Currey <ruscur@russell.cc>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] PCI: provide pcibios_sriov_add_vfs
Date: Fri, 14 Dec 2018 05:12:06 -0800 [thread overview]
Message-ID: <20181214131206.GA2606@infradead.org> (raw)
In-Reply-To: <20181213175428.87520-1-sebott@linux.ibm.com>
On Thu, Dec 13, 2018 at 06:54:27PM +0100, Sebastian Ott wrote:
> Move VF detection and device creation code to weak functions
> such that architectures can provide a different implementation.
No magic weak functions please. If you really have a reason to
override the implementation add a proper Kconfig symbol and
an explicit override.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Sebastian Ott <sebott@linux.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-pci@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Bjorn Helgaas <helgaas@kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] PCI: provide pcibios_sriov_add_vfs
Date: Fri, 14 Dec 2018 05:12:06 -0800 [thread overview]
Message-ID: <20181214131206.GA2606@infradead.org> (raw)
In-Reply-To: <20181213175428.87520-1-sebott@linux.ibm.com>
On Thu, Dec 13, 2018 at 06:54:27PM +0100, Sebastian Ott wrote:
> Move VF detection and device creation code to weak functions
> such that architectures can provide a different implementation.
No magic weak functions please. If you really have a reason to
override the implementation add a proper Kconfig symbol and
an explicit override.
next prev parent reply other threads:[~2018-12-14 13:12 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 12:34 [PATCH 0/2] sriov enablement on s390 Sebastian Ott
2018-09-12 12:34 ` [PATCH 1/2] pci: provide pcibios_sriov_add_vfs Sebastian Ott
2018-09-12 12:34 ` [PATCH 2/2] s390/pci: handle function enumeration after sriov enablement Sebastian Ott
2018-09-12 13:02 ` [PATCH 0/2] sriov enablement on s390 Bjorn Helgaas
2018-09-12 14:40 ` Benjamin Herrenschmidt
2018-09-13 12:41 ` Sebastian Ott
2018-09-13 12:41 ` [PATCH 1/2] pci: provide add_vfs/del_vfs callbacks Sebastian Ott
2018-09-13 12:41 ` [PATCH 2/2] s390/pci: handle function enumeration after sriov enablement Sebastian Ott
2018-10-10 12:55 ` [PATCH 0/2] sriov enablement on s390 Sebastian Ott
2018-10-10 12:55 ` Sebastian Ott
2018-10-10 16:26 ` Bjorn Helgaas
2018-10-10 16:26 ` Bjorn Helgaas
2018-12-05 13:45 ` Sebastian Ott
2018-12-05 13:45 ` Sebastian Ott
2018-12-12 21:54 ` Bjorn Helgaas
2018-12-12 21:54 ` Bjorn Helgaas
2018-12-13 17:54 ` [PATCH 1/2] PCI: provide pcibios_sriov_add_vfs Sebastian Ott
2018-12-13 17:54 ` Sebastian Ott
2018-12-14 13:12 ` Christoph Hellwig [this message]
2018-12-14 13:12 ` Christoph Hellwig
2018-12-13 17:54 ` [PATCH 2/2] s390/pci: handle function enumeration after sriov enablement Sebastian Ott
2018-12-13 17:54 ` Sebastian Ott
2018-12-14 13:12 ` Christoph Hellwig
2018-12-14 13:12 ` Christoph Hellwig
2018-12-14 13:18 ` Christoph Hellwig
2018-12-14 13:18 ` Christoph Hellwig
2018-12-17 17:30 ` Sebastian Ott
2018-12-17 17:30 ` Sebastian Ott
2018-12-17 17:35 ` Christoph Hellwig
2018-12-17 17:35 ` Christoph Hellwig
2018-12-18 10:16 ` [PATCH 1/2] PCI/IOV: provide flag to skip VF scanning Sebastian Ott
2018-12-18 10:16 ` Sebastian Ott
2018-12-19 7:52 ` Christoph Hellwig
2018-12-19 7:52 ` Christoph Hellwig
2018-12-20 20:07 ` Bjorn Helgaas
2018-12-20 20:07 ` Bjorn Helgaas
2018-12-21 14:14 ` [PATCH 1/3] PCI/IOV: factor out sriov_add_vfs Sebastian Ott
2018-12-21 14:14 ` Sebastian Ott
2018-12-21 14:14 ` [PATCH 2/3] PCI/IOV: provide flag to skip VF scanning Sebastian Ott
2018-12-21 14:14 ` Sebastian Ott
2018-12-21 14:14 ` [PATCH 3/3] s390/pci: " Sebastian Ott
2018-12-21 14:14 ` Sebastian Ott
2018-12-21 14:19 ` [PATCH 1/2] PCI/IOV: provide flag to " Sebastian Ott
2018-12-21 14:19 ` Sebastian Ott
2019-01-02 1:14 ` Bjorn Helgaas
2019-01-02 1:14 ` Bjorn Helgaas
2018-12-18 10:16 ` [PATCH 2/2] s390/pci: " Sebastian Ott
2018-12-18 10:16 ` Sebastian Ott
2018-12-19 7:52 ` Christoph Hellwig
2018-12-19 7:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214131206.GA2606@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=ruscur@russell.cc \
--cc=sebott@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.