From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=oQb0=OX=vger.kernel.org=linux-block-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B3077C43387
	for <linux-block@archiver.kernel.org>; Fri, 14 Dec 2018 15:44:07 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id EFCBB206E0
	for <linux-block@archiver.kernel.org>; Fri, 14 Dec 2018 15:44:07 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727540AbeLNPoG (ORCPT <rfc822;linux-block@archiver.kernel.org>);
        Fri, 14 Dec 2018 10:44:06 -0500
Received: from verein.lst.de ([213.95.11.211]:48235 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727340AbeLNPoG (ORCPT <rfc822;linux-block@vger.kernel.org>);
        Fri, 14 Dec 2018 10:44:06 -0500
Received: by newverein.lst.de (Postfix, from userid 2407)
        id 8249468DF1; Fri, 14 Dec 2018 16:44:05 +0100 (CET)
Date:   Fri, 14 Dec 2018 16:44:05 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Sagi Grimberg <sagi@grimberg.me>
Cc:     linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
        linux-rdma@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
        Keith Busch <keith.busch@intel.com>,
        Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v3 3/6] nvme-core: optionally poll sync commands
Message-ID: <20181214154405.GB24417@lst.de>
References: <20181213213410.9841-1-sagi@grimberg.me> <20181213213410.9841-4-sagi@grimberg.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181213213410.9841-4-sagi@grimberg.me>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-block-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-block.vger.kernel.org>
X-Mailing-List: linux-block@vger.kernel.org

On Thu, Dec 13, 2018 at 01:34:07PM -0800, Sagi Grimberg wrote:
> Pass poll bool to indicate that we need it to poll. This prepares us for
> polling support in nvmf since connect is an I/O that will be queued
> and has to be polled in order to complete. If poll is passed,
> we call nvme_execute_rq_polled which sends the requests and polls
> for its completion.

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>

From mboxrd@z Thu Jan  1 00:00:00 1970
From: hch@lst.de (Christoph Hellwig)
Date: Fri, 14 Dec 2018 16:44:05 +0100
Subject: [PATCH v3 3/6] nvme-core: optionally poll sync commands
In-Reply-To: <20181213213410.9841-4-sagi@grimberg.me>
References: <20181213213410.9841-1-sagi@grimberg.me>
 <20181213213410.9841-4-sagi@grimberg.me>
Message-ID: <20181214154405.GB24417@lst.de>

On Thu, Dec 13, 2018@01:34:07PM -0800, Sagi Grimberg wrote:
> Pass poll bool to indicate that we need it to poll. This prepares us for
> polling support in nvmf since connect is an I/O that will be queued
> and has to be polled in order to complete. If poll is passed,
> we call nvme_execute_rq_polled which sends the requests and polls
> for its completion.

Looks fine,

Reviewed-by: Christoph Hellwig <hch at lst.de>