From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH] net/failsafe: remove unnecessary debug messages Date: Fri, 14 Dec 2018 11:35:52 -0800 Message-ID: <20181214193552.12408-1-stephen@networkplumber.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org, Stephen Hemminger , Stephen Hemminger To: gaetan.rivet@6wind.com Return-path: Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 45DE21B9C8 for ; Fri, 14 Dec 2018 20:36:02 +0100 (CET) Received: by mail-pf1-f195.google.com with SMTP id i12so3294738pfo.7 for ; Fri, 14 Dec 2018 11:36:02 -0800 (PST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The failsafe driver spews messages every time it is polling making debugging other things more difficult. Just remove it. Example: net_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-plug alarm net_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-plug alarm ... Signed-off-by: Stephen Hemminger --- drivers/net/failsafe/failsafe_private.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h index 7e3189685901..0dfea65c2a3c 100644 --- a/drivers/net/failsafe/failsafe_private.h +++ b/drivers/net/failsafe/failsafe_private.h @@ -399,9 +399,6 @@ fs_lock(struct rte_eth_dev *dev, unsigned int is_alarm) return ret; } } - DEBUG("Hot-plug mutex was locked by thread %" FS_THREADID_FMT "%s", - (FS_THREADID_TYPE)pthread_self(), - PRIV(dev)->alarm_lock ? " by the hot-plug alarm" : ""); return ret; } @@ -413,7 +410,6 @@ static inline void fs_unlock(struct rte_eth_dev *dev, unsigned int is_alarm) { int ret; - unsigned int prev_alarm_lock = PRIV(dev)->alarm_lock; if (is_alarm) { RTE_ASSERT(PRIV(dev)->alarm_lock == 1); @@ -422,10 +418,6 @@ fs_unlock(struct rte_eth_dev *dev, unsigned int is_alarm) ret = pthread_mutex_unlock(&PRIV(dev)->hotplug_mutex); if (ret) ERROR("Cannot unlock hot-plug mutex(%s)", strerror(ret)); - else - DEBUG("Hot-plug mutex was unlocked by thread %" FS_THREADID_FMT "%s", - (FS_THREADID_TYPE)pthread_self(), - prev_alarm_lock ? " by the hot-plug alarm" : ""); } /* -- 2.19.2