From: Christoph Hellwig <hch@lst.de>
To: Richard Weinberger <richard@nod.at>
Cc: zhangjun <openzhangj@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
"Darrick J . Wong" <darrick.wong@oracle.com>,
hch@lst.de, bfoster@redhat.com,
Dave Chinner <david@fromorbit.com>,
akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
mhocko@suse.com, n-horiguchi@ah.jp.nec.com,
mgorman@techsingularity.net, aarcange@redhat.com,
willy@infradead.org, linux@dominikbrodowski.net,
linux-mm@kvack.org, Gao Xiang <gaoxiang25@huawei.com>
Subject: Re: [PATCH] fix page_count in ->iomap_migrate_page()
Date: Sat, 15 Dec 2018 11:51:12 +0100 [thread overview]
Message-ID: <20181215105112.GC1575@lst.de> (raw)
In-Reply-To: <1618433.IpySj692Hd@blindfold>
FYI, for iomap we got a patch to just increment the page count when
setting the private data, and it finally got merged into mainline after
a while.
Not that it totally makes sense to me, but it is what it is. It would
just be nice if set_page_private took care of it and we had a
clear_page_private to undo it, making the whole scheme at lot more
obvious.
next prev parent reply other threads:[~2018-12-15 10:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 5:56 [PATCH] fix page_count in ->iomap_migrate_page() zhangjun
2018-12-14 11:25 ` Richard Weinberger
2018-12-14 11:25 ` Richard Weinberger
2018-12-14 12:26 ` Gao Xiang
2018-12-14 13:35 ` Richard Weinberger
2018-12-14 13:55 ` Gao Xiang
2018-12-15 10:51 ` Christoph Hellwig [this message]
2018-12-15 11:17 ` Richard Weinberger
2018-12-15 4:26 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181215105112.GC1575@lst.de \
--to=hch@lst.de \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=gaoxiang25@huawei.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@dominikbrodowski.net \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=openzhangj@gmail.com \
--cc=richard@nod.at \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.