From: Petr Vorel <petr.vorel@gmail.com>
To: Luca Boccassi <bluca@debian.org>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
Petr Vorel <pvorel@suse.cz>
Subject: Re: [PATCH iproute2 2/4] testsuite: declare dependency between $(TESTS) and generate_nlmsg
Date: Sat, 15 Dec 2018 17:22:13 +0100 [thread overview]
Message-ID: <20181215162212.GA683@x230> (raw)
In-Reply-To: <20181215153051.13166-2-bluca@debian.org>
Hi Luca,
> Parallel make from the top level directory fails since tests are at the
> same time as generate_nlmsg:
> $ make check -j4
> ...
> cd testsuite && make && make alltests
> echo "Entering iproute2" && cd iproute2 && make configure && cd ..;
> Entering iproute2
> make -C tools
> Removing results dir ...
> make[1]: ./tools/generate_nlmsg: Command not found
> make[1]: ./tools/generate_nlmsg: Command not found
> Makefile:64: recipe for target 'ip/netns/set_nsid_batch.t' failed
> make[1]: *** [ip/netns/set_nsid_batch.t] Error 127
> make[1]: ./tools/generate_nlmsg: Command not found
> make[1]: *** Waiting for unfinished jobs....
> Makefile:64: recipe for target 'ip/netns/set_nsid.t' failed
> make[1]: *** [ip/netns/set_nsid.t] Error 127
> Makefile:64: recipe for target 'ip/link/show_dev_wo_vf_rate.t' failed
> make[1]: *** [ip/link/show_dev_wo_vf_rate.t] Error 127
> CC generate_nlmsg
> Makefile:123: recipe for target 'check' failed
> make: *** [check] Error 2
> Add an explicit dependency in testuite/Makefile's $(TESTS) rule so
> that the tool correctly gets compiled before any test runs.
> Fixes: 3537633dcf44 ("testsuite: Generate generate_nlmsg when needed")
> Cc: petr.vorel@gmail.com
> Signed-off-by: Luca Boccassi <bluca@debian.org>
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Tested-by: Petr Vorel <petr.vorel@gmail.com>
Again, thanks for fix.
Kind regards,
Petr
next prev parent reply other threads:[~2018-12-15 16:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-15 15:30 [PATCH iproute2 1/4] Makefile: have check target depend on all Luca Boccassi
2018-12-15 15:30 ` [PATCH iproute2 2/4] testsuite: declare dependency between $(TESTS) and generate_nlmsg Luca Boccassi
2018-12-15 16:22 ` Petr Vorel [this message]
2018-12-15 15:30 ` [PATCH iproute2 3/4] tests: delete dummy interface after default route test Luca Boccassi
2018-12-15 16:32 ` Petr Vorel
2018-12-16 13:52 ` Luca Boccassi
2018-12-15 15:33 ` [PATCH iproute2 4/4] testsuite: remove gre kmods if the test loads them Luca Boccassi
2018-12-15 17:37 ` Petr Vorel
2018-12-16 13:52 ` Luca Boccassi
2018-12-15 16:13 ` [PATCH iproute2 1/4] Makefile: have check target depend on all Petr Vorel
2018-12-16 13:47 ` [PATCH iproute2 v2 " Luca Boccassi
2018-12-16 13:47 ` [PATCH iproute2 v2 2/4] testsuite: declare dependency between $(TESTS) and generate_nlmsg Luca Boccassi
2018-12-16 13:47 ` [PATCH iproute2 v2 3/4] testsuite: delete dummy interface after default route test Luca Boccassi
2018-12-16 20:13 ` Petr Vorel
2018-12-16 13:47 ` [PATCH iproute2 v2 4/4] testsuite: remove gre kmods if the test loads them Luca Boccassi
2018-12-16 20:21 ` Petr Vorel
2018-12-16 20:57 ` Luca Boccassi
2018-12-16 20:55 ` [PATCH iproute2 v3 1/4] Makefile: have check target depend on all Luca Boccassi
2018-12-16 20:55 ` [PATCH iproute2 v3 2/4] testsuite: declare dependency between $(TESTS) and generate_nlmsg Luca Boccassi
2018-12-16 20:55 ` [PATCH iproute2 v3 3/4] testsuite: delete dummy interface after default route test Luca Boccassi
2018-12-16 20:55 ` [PATCH iproute2 v3 4/4] testsuite: remove gre kmods if the test loads them Luca Boccassi
2018-12-16 21:10 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181215162212.GA683@x230 \
--to=petr.vorel@gmail.com \
--cc=bluca@debian.org \
--cc=netdev@vger.kernel.org \
--cc=pvorel@suse.cz \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.