From: Andrew Lunn <andrew@lunn.ch>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: Woojung.Huh@microchip.com, devicetree@vger.kernel.org,
f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com,
netdev@vger.kernel.org, driverdev-devel@linuxdriverproject.org,
UNGLinuxDriver@microchip.com, davem@davemloft.net
Subject: Re: [PATCH 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
Date: Sun, 16 Dec 2018 09:18:17 +0100 [thread overview]
Message-ID: <20181216081817.GC18287@lunn.ch> (raw)
In-Reply-To: <20181216075741.13827-2-sergio.paracuellos@gmail.com>
On Sun, Dec 16, 2018 at 08:57:41AM +0100, Sergio Paracuellos wrote:
> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
> .../devicetree/bindings/net/dsa/ksz.txt | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> index 0f407fb371ce..9e715358cebb 100644
> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
> };
> };
> };
> +
> +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
> +
> + eth0: ethernet@10001000 {
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> +
> + i2c0: i2c@f8008000 {
> + ksz9897: ksz9897@0 {
Hi Sergio
You should use a generic name here. Plus the @X needs to be the same as the reg value.
So switch: ksz9897@5f.
Andrew
next prev parent reply other threads:[~2018-12-16 8:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 7:57 [PATCH 1/2] net: dsa: ksz9477: add I2C managed mode support Sergio Paracuellos
2018-12-16 7:57 ` [PATCH 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode Sergio Paracuellos
2018-12-16 8:18 ` Andrew Lunn [this message]
2018-12-16 8:32 ` Sergio Paracuellos
2018-12-16 8:15 ` [PATCH 1/2] net: dsa: ksz9477: add I2C managed mode support Andrew Lunn
2018-12-16 8:35 ` Sergio Paracuellos
2018-12-16 8:44 ` Andrew Lunn
2018-12-17 6:54 ` Dan Carpenter
2018-12-17 18:22 ` Sergio Paracuellos
2018-12-17 19:11 ` Dan Carpenter
2018-12-17 20:46 ` Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181216081817.GC18287@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.