From: Jonathan Cameron <jic23@kernel.org>
To: Slawomir Stepien <sst@poczta.fm>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH 1/2] staging: iio: adc: ad7280a: split ad7280_channel_init() to more functions
Date: Sun, 16 Dec 2018 12:33:53 +0000 [thread overview]
Message-ID: <20181216123353.5fc52d21@archlinux> (raw)
In-Reply-To: <20181212171906.GB1738@t480s.localdomain>
On Wed, 12 Dec 2018 18:19:06 +0100
Slawomir Stepien <sst@poczta.fm> wrote:
> On gru 12, 2018 18:02, Slawomir Stepien wrote:
> > The ad7280_channel_init function has been split into more specific
> > functions to increase the code readability.
> >
> > The setting of channel's scan_type.shift to 0, has been removed, since
> > it is the default value.
> >
> > Signed-off-by: Slawomir Stepien <sst@poczta.fm>
> > ---
> > Since v1:
> > * Added ad7280_init_dev_channels function.
> > * New functions are now using struct iio_chan_spec rather than struct
> > ad7280_state.
> > * Channel's number on device calculation has been moved to macros.
> > * scan_type.shift assigned has been removed.
> > ---
>
> Sorry about not marking this as v2 in the subject line :( I'll fix that on next
> version (if that happens ;)).
>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to see if they can break it.
Thanks,
Jonathan
next prev parent reply other threads:[~2018-12-16 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 17:02 [PATCH v2 0/2] staging: iio: adc: ad7280a: channel and attr init refactor Slawomir Stepien
2018-12-12 17:02 ` [PATCH 1/2] staging: iio: adc: ad7280a: split ad7280_channel_init() to more functions Slawomir Stepien
2018-12-12 17:19 ` Slawomir Stepien
2018-12-16 12:33 ` Jonathan Cameron [this message]
2018-12-12 17:02 ` [PATCH 2/2] staging: iio: adc: ad7280a: split ad7280_attr_init() " Slawomir Stepien
2018-12-12 17:20 ` Slawomir Stepien
2018-12-16 12:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181216123353.5fc52d21@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=sst@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.