From: Jens Axboe <axboe@kernel.dk>
To: linux-fsdevel@vger.kernel.org, linux-aio@kvack.org
Cc: hch@lst.de, viro@zeniv.linux.org.uk, Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 7/7] aio: abstract out io_event filler helper
Date: Sun, 16 Dec 2018 10:01:16 -0700 [thread overview]
Message-ID: <20181216170116.16944-8-axboe@kernel.dk> (raw)
In-Reply-To: <20181216170116.16944-1-axboe@kernel.dk>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
fs/aio.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/fs/aio.c b/fs/aio.c
index 06c8bcc72496..173f1f79dc8f 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -1063,6 +1063,15 @@ static inline void iocb_put(struct aio_kiocb *iocb)
}
}
+static void aio_fill_event(struct io_event *ev, struct aio_kiocb *iocb,
+ long res, long res2)
+{
+ ev->obj = (u64)(unsigned long)iocb->ki_user_iocb;
+ ev->data = iocb->ki_user_data;
+ ev->res = res;
+ ev->res2 = res2;
+}
+
/* aio_complete
* Called when the io request on the given iocb is complete.
*/
@@ -1090,10 +1099,7 @@ static void aio_complete(struct aio_kiocb *iocb, long res, long res2)
ev_page = kmap_atomic(ctx->ring_pages[pos / AIO_EVENTS_PER_PAGE]);
event = ev_page + pos % AIO_EVENTS_PER_PAGE;
- event->obj = (u64)(unsigned long)iocb->ki_user_iocb;
- event->data = iocb->ki_user_data;
- event->res = res;
- event->res2 = res2;
+ aio_fill_event(event, iocb, res, res2);
kunmap_atomic(ev_page);
flush_dcache_page(ctx->ring_pages[pos / AIO_EVENTS_PER_PAGE]);
--
2.17.1
next prev parent reply other threads:[~2018-12-16 17:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 17:01 [PATCHSET] aio cleanups and optimizations for 4.21 Jens Axboe
2018-12-16 17:01 ` [PATCH 1/7] aio: use assigned completion handler Jens Axboe
2018-12-16 17:01 ` [PATCH 2/7] aio: separate out ring reservation from req allocation Jens Axboe
2018-12-16 17:01 ` [PATCH 3/7] aio: don't zero entire aio_kiocb aio_get_req() Jens Axboe
2018-12-16 17:01 ` [PATCH 4/7] aio: only use blk plugs for > 2 depth submissions Jens Axboe
2018-12-16 17:01 ` [PATCH 5/7] aio: use iocb_put() instead of open coding it Jens Axboe
2018-12-16 17:01 ` [PATCH 6/7] aio: split out iocb copy from io_submit_one() Jens Axboe
2018-12-16 17:01 ` Jens Axboe [this message]
2018-12-21 19:30 ` [PATCHSET] aio cleanups and optimizations for 4.21 Jeff Moyer
2018-12-22 15:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181216170116.16944-8-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.