From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PATCH 3/4] blk-mq: deal with shared queue mapping reliably
Date: Sun, 16 Dec 2018 13:39:37 -0500 [thread overview]
Message-ID: <20181216183937.GA25476@redhat.com> (raw)
In-Reply-To: <20181216161650.GD9957@lst.de>
On Sun, Dec 16 2018 at 11:16am -0500,
Christoph Hellwig <hch@lst.de> wrote:
> On Sun, Dec 16, 2018 at 10:25:16AM +0800, Ming Lei wrote:
> > This patch sets map->nr_queues as zero explictly if there is zero
> > queues for such queue type, then blk_mq_map_swqueue() can become
> > more robust to deal with shared mappings.
>
> This looks a lot more clumsy than what we had before, can you explain
> what additional robustnes it buys us?
It enables nvme IO to complete on my testbed with for-4.21/block
changes, this NUMA layout is what triggered Ming's work:
# numactl --hardware
available: 2 nodes (0-1)
node 0 cpus: 0 2 4 6 8 10 12 14
node 0 size: 128605 MB
node 0 free: 128092 MB
node 1 cpus: 1 3 5 7 9 11 13 15
node 1 size: 128997 MB
node 1 free: 128529 MB
node distances:
node 0 1
0: 10 21
1: 21 10
Without the aggregate changes from this patchset (1-3 anyway) I get IO
hangs in blkdev_fsync().
With that in mind, Jens needs these fixes (or something comparable)
ASAP.
Tested-by: Mike Snitzer <snitzer@redhat.com>
next prev parent reply other threads:[~2018-12-16 18:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 2:25 [PATCH 0/4] blk-mq: queue mapping fix & improvement Ming Lei
2018-12-16 2:25 ` [PATCH 1/4] nvme-pci: correct mapping for poll queue(s) Ming Lei
2018-12-16 16:11 ` Christoph Hellwig
2018-12-17 1:00 ` Ming Lei
2018-12-17 7:06 ` Christoph Hellwig
2018-12-17 7:22 ` Ming Lei
2018-12-16 2:25 ` [PATCH 2/4] blk-mq: fix allocation for queue mapping table Ming Lei
2018-12-16 16:15 ` Christoph Hellwig
2018-12-16 2:25 ` [PATCH 3/4] blk-mq: deal with shared queue mapping reliably Ming Lei
2018-12-16 16:16 ` Christoph Hellwig
2018-12-16 18:39 ` Mike Snitzer [this message]
2018-12-16 19:12 ` Jens Axboe
2018-12-17 1:04 ` Ming Lei
2018-12-17 7:44 ` Christoph Hellwig
2018-12-17 8:38 ` Ming Lei
2018-12-17 1:27 ` Ming Lei
2018-12-16 2:25 ` [PATCH 4/4] blk-mq-debugfs: export hctx->type Ming Lei
2018-12-16 16:17 ` Christoph Hellwig
2018-12-16 19:12 ` Jens Axboe
2018-12-17 1:06 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181216183937.GA25476@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.