From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: yupeng <yupeng0921@gmail.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, keith.busch@intel.com,
axboe@fb.com, hch@lst.de, sagi@grimberg.me
Subject: Re: [PATCH v3 2/2] trace nvme submit queue status
Date: Mon, 17 Dec 2018 12:11:46 +0100 [thread overview]
Message-ID: <20181217111146.GA6126@lst.de> (raw)
In-Reply-To: <11554384-e0a9-0bde-97e9-228b29e6b641@suse.de>
On Mon, Dec 17, 2018 at 09:33:24AM +0100, Johannes Thumshirn wrote:
> Is the addition of a trace_pci.h really needed? Why can't you just put
> it in trace.h?
Agreed. Especially as the concepts actually are generic, so we could
actually add the trace point to the rdma and fc transports as well
(not that they would be all that useful, so we probably shouldn't).
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v3 2/2] trace nvme submit queue status
Date: Mon, 17 Dec 2018 12:11:46 +0100 [thread overview]
Message-ID: <20181217111146.GA6126@lst.de> (raw)
In-Reply-To: <11554384-e0a9-0bde-97e9-228b29e6b641@suse.de>
On Mon, Dec 17, 2018@09:33:24AM +0100, Johannes Thumshirn wrote:
> Is the addition of a trace_pci.h really needed? Why can't you just put
> it in trace.h?
Agreed. Especially as the concepts actually are generic, so we could
actually add the trace point to the rdma and fc transports as well
(not that they would be all that useful, so we probably shouldn't).
next prev parent reply other threads:[~2018-12-17 11:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 8:06 [PATCH v3 1/2] share nvme trace event helper functions with other modules yupeng
2018-12-17 8:06 ` yupeng
2018-12-17 8:06 ` [PATCH v3 2/2] trace nvme submit queue status yupeng
2018-12-17 8:06 ` yupeng
2018-12-17 8:33 ` Johannes Thumshirn
2018-12-17 8:33 ` Johannes Thumshirn
2018-12-17 11:11 ` Christoph Hellwig [this message]
2018-12-17 11:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217111146.GA6126@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=yupeng0921@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.