From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEFF5C43387 for ; Mon, 17 Dec 2018 10:38:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98FBF2133F for ; Mon, 17 Dec 2018 10:38:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732061AbeLQKiJ convert rfc822-to-8bit (ORCPT ); Mon, 17 Dec 2018 05:38:09 -0500 Received: from smtprelay06.ispgateway.de ([80.67.31.95]:40045 "EHLO smtprelay06.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726991AbeLQKiJ (ORCPT ); Mon, 17 Dec 2018 05:38:09 -0500 X-Greylist: delayed 606 seconds by postgrey-1.27 at vger.kernel.org; Mon, 17 Dec 2018 05:38:08 EST Received: from [89.1.81.74] (helo=karo-electronics.de) by smtprelay06.ispgateway.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gYq7v-0005oC-F2; Mon, 17 Dec 2018 11:27:55 +0100 Date: Mon, 17 Dec 2018 11:27:52 +0100 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Aisheng Dong Cc: Stephen Boyd , "linux-clk@vger.kernel.org" , "mturquette@baylibre.com" , dl-linux-imx , "kernel@pengutronix.de" , Fabio Estevam , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH V9 2/7] clk: imx: add scu clock common part Message-ID: <20181217112752.07e43d05@karo-electronics.de> In-Reply-To: References: <1543934041-12572-1-git-send-email-aisheng.dong@nxp.com> <1543934041-12572-3-git-send-email-aisheng.dong@nxp.com> <154447896872.17204.13777399275077720705@swboyd.mtv.corp.google.com> Organization: Ka-Ro electronics GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Df-Sender: bHdAa2Fyby1lbGVjdHJvbmljcy5kZQ== Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi, On Tue, 11 Dec 2018 03:35:48 +0000 Aisheng Dong wrote: > > -----Original Message----- > > From: Stephen Boyd [mailto:sboyd@kernel.org] > > Quoting Aisheng DONG (2018-12-04 06:39:25) > > > diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig index > > > 43a3ecc..63e7b01 100644 > > > --- a/drivers/clk/imx/Kconfig > > > +++ b/drivers/clk/imx/Kconfig > > > @@ -3,3 +3,7 @@ > > > config MXC_CLK > > > bool > > > depends on ARCH_MXC > > > + > > > +config MXC_CLK_SCU > > > > Is there any reason to make this a hidden option instead of making it a > > selectable option? It can still depend on ARCH_MXC and ARM64, but otherwise > > it should be compilable as long as CONFIG_IMX_SCU is defined (this should > > also be a config we depend on here). > > > > This is mostly following the exist using that CLK is selected by SoC config option. > https://patchwork.kernel.org/patch/10677309/ > > As CLK usually is required for platform to run well, so we did not make it selectable. > > > > + bool > > > + depends on ARCH_MXC && ARM64 > > > diff --git a/drivers/clk/imx/Makefile b/drivers/clk/imx/Makefile index > > > f850424..4abed37 100644 > > > --- a/drivers/clk/imx/Makefile > > > +++ b/drivers/clk/imx/Makefile > > > @@ -20,6 +20,9 @@ obj-$(CONFIG_MXC_CLK) += \ > > > clk-pllv4.o \ > > > clk-sccg-pll.o > > > > > > +obj-$(CONFIG_MXC_CLK_SCU) += \ > > > + clk-scu.o > > > + > > > obj-$(CONFIG_SOC_IMX1) += clk-imx1.o > > > obj-$(CONFIG_SOC_IMX21) += clk-imx21.o > > > obj-$(CONFIG_SOC_IMX25) += clk-imx25.o diff --git > > > a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c new file mode > > > 100644 index 0000000..ec8a471 > > > --- /dev/null > > > +++ b/drivers/clk/imx/clk-scu.c > > > @@ -0,0 +1,265 @@ > > > +// SPDX-License-Identifier: GPL-2.0+ > > > +/* > > > + * Copyright 2018 NXP > > > + * Dong Aisheng > > > + */ > > > + > > > +#include > > > +#include > > > +#include > > > + > > > +#include "clk-scu.h" > > > + > > > +struct imx_sc_ipc *ccm_ipc_handle; > > > > Why does this need to be a global? Can it be in each clk_scu instance instead? > > > > No, no need to be in each clk_scu instance. > There's only one handler. > Shouldn't it be 'static'? Lothar Waßmann From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22AE8C43387 for ; Mon, 17 Dec 2018 10:28:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC7C52146E for ; Mon, 17 Dec 2018 10:28:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ogiq1M0v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC7C52146E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=KARO-electronics.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4JBkUwTkKtW2B0sNj3Ogw8BCnWEj/NbihnUYbcwsZB8=; b=ogiq1M0v6dZLDQ RH3WkXJ/oSvRGGgOwjxD67hMOkOrh4DqAEtAw9DtEkh5+X/DGHirfA6dDFxEvzs4rvuW75KbGpnyF Z8ratgXfLEKCvHzQXuil7ZTm69jiZ5GEc3igeY60eF2wXggvIgdqPpJj60GRdm+3MRhvTAkY7FTVy AEFy112zXccr1L8mfialDJudagXcbzud0SDZ1MIOJ+dq6vPvzGrCuC7MhxAe2fP2zWdcBpSYT0MW9 M4uNQzkQxmPKPKW/3iZuLmR3yZWtAWNY30+qdqwP1oRJI5MzljbgKJvmXsWMYUAcMZQI2kQfzLdoB kq6Kuxz4iorazbltuP+g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gYq8I-0007Lm-8C; Mon, 17 Dec 2018 10:28:18 +0000 Received: from smtprelay06.ispgateway.de ([80.67.31.95]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gYq8E-0007KY-07 for linux-arm-kernel@lists.infradead.org; Mon, 17 Dec 2018 10:28:16 +0000 Received: from [89.1.81.74] (helo=karo-electronics.de) by smtprelay06.ispgateway.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gYq7v-0005oC-F2; Mon, 17 Dec 2018 11:27:55 +0100 Date: Mon, 17 Dec 2018 11:27:52 +0100 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Aisheng Dong Subject: Re: [PATCH V9 2/7] clk: imx: add scu clock common part Message-ID: <20181217112752.07e43d05@karo-electronics.de> In-Reply-To: References: <1543934041-12572-1-git-send-email-aisheng.dong@nxp.com> <1543934041-12572-3-git-send-email-aisheng.dong@nxp.com> <154447896872.17204.13777399275077720705@swboyd.mtv.corp.google.com> Organization: Ka-Ro electronics GmbH MIME-Version: 1.0 X-Df-Sender: bHdAa2Fyby1lbGVjdHJvbmljcy5kZQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181217_022814_037252_B179F5C9 X-CRM114-Status: GOOD ( 15.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , "mturquette@baylibre.com" , dl-linux-imx , "kernel@pengutronix.de" , Fabio Estevam , "shawnguo@kernel.org" , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiBUdWUsIDExIERlYyAyMDE4IDAzOjM1OjQ4ICswMDAwIEFpc2hlbmcgRG9uZyB3cm90 ZToKPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gPiBGcm9tOiBTdGVwaGVuIEJveWQg W21haWx0bzpzYm95ZEBrZXJuZWwub3JnXQo+ID4gUXVvdGluZyBBaXNoZW5nIERPTkcgKDIwMTgt MTItMDQgMDY6Mzk6MjUpICAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvY2xrL2lteC9LY29u ZmlnIGIvZHJpdmVycy9jbGsvaW14L0tjb25maWcgaW5kZXgKPiA+ID4gNDNhM2VjYy4uNjNlN2Iw MSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9jbGsvaW14L0tjb25maWcKPiA+ID4gKysrIGIv ZHJpdmVycy9jbGsvaW14L0tjb25maWcKPiA+ID4gQEAgLTMsMyArMyw3IEBACj4gPiA+ICBjb25m aWcgTVhDX0NMSwo+ID4gPiAgICAgICAgIGJvb2wKPiA+ID4gICAgICAgICBkZXBlbmRzIG9uIEFS Q0hfTVhDCj4gPiA+ICsKPiA+ID4gK2NvbmZpZyBNWENfQ0xLX1NDVSAgCj4gPiAKPiA+IElzIHRo ZXJlIGFueSByZWFzb24gdG8gbWFrZSB0aGlzIGEgaGlkZGVuIG9wdGlvbiBpbnN0ZWFkIG9mIG1h a2luZyBpdCBhCj4gPiBzZWxlY3RhYmxlIG9wdGlvbj8gSXQgY2FuIHN0aWxsIGRlcGVuZCBvbiBB UkNIX01YQyBhbmQgQVJNNjQsIGJ1dCBvdGhlcndpc2UKPiA+IGl0IHNob3VsZCBiZSBjb21waWxh YmxlIGFzIGxvbmcgYXMgQ09ORklHX0lNWF9TQ1UgaXMgZGVmaW5lZCAodGhpcyBzaG91bGQKPiA+ IGFsc28gYmUgYSBjb25maWcgd2UgZGVwZW5kIG9uIGhlcmUpLgo+ID4gICAKPiAKPiBUaGlzIGlz IG1vc3RseSBmb2xsb3dpbmcgdGhlIGV4aXN0IHVzaW5nIHRoYXQgQ0xLIGlzIHNlbGVjdGVkIGJ5 IFNvQyBjb25maWcgb3B0aW9uLgo+IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gv MTA2NzczMDkvCj4gCj4gQXMgQ0xLIHVzdWFsbHkgaXMgcmVxdWlyZWQgZm9yIHBsYXRmb3JtIHRv IHJ1biB3ZWxsLCBzbyB3ZSBkaWQgbm90IG1ha2UgaXQgc2VsZWN0YWJsZS4KPiAKPiA+ID4gKyAg ICAgICBib29sCj4gPiA+ICsgICAgICAgZGVwZW5kcyBvbiBBUkNIX01YQyAmJiBBUk02NAo+ID4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9jbGsvaW14L01ha2VmaWxlIGIvZHJpdmVycy9jbGsvaW14 L01ha2VmaWxlIGluZGV4Cj4gPiA+IGY4NTA0MjQuLjRhYmVkMzcgMTAwNjQ0Cj4gPiA+IC0tLSBh L2RyaXZlcnMvY2xrL2lteC9NYWtlZmlsZQo+ID4gPiArKysgYi9kcml2ZXJzL2Nsay9pbXgvTWFr ZWZpbGUKPiA+ID4gQEAgLTIwLDYgKzIwLDkgQEAgb2JqLSQoQ09ORklHX01YQ19DTEspICs9IFwK PiA+ID4gICAgICAgICBjbGstcGxsdjQubyBcCj4gPiA+ICAgICAgICAgY2xrLXNjY2ctcGxsLm8K PiA+ID4KPiA+ID4gK29iai0kKENPTkZJR19NWENfQ0xLX1NDVSkgKz0gXAo+ID4gPiArICAgICAg IGNsay1zY3Uubwo+ID4gPiArCj4gPiA+ICBvYmotJChDT05GSUdfU09DX0lNWDEpICAgKz0gY2xr LWlteDEubwo+ID4gPiAgb2JqLSQoQ09ORklHX1NPQ19JTVgyMSkgICs9IGNsay1pbXgyMS5vCj4g PiA+ICBvYmotJChDT05GSUdfU09DX0lNWDI1KSAgKz0gY2xrLWlteDI1Lm8gZGlmZiAtLWdpdAo+ ID4gPiBhL2RyaXZlcnMvY2xrL2lteC9jbGstc2N1LmMgYi9kcml2ZXJzL2Nsay9pbXgvY2xrLXNj dS5jIG5ldyBmaWxlIG1vZGUKPiA+ID4gMTAwNjQ0IGluZGV4IDAwMDAwMDAuLmVjOGE0NzEKPiA+ ID4gLS0tIC9kZXYvbnVsbAo+ID4gPiArKysgYi9kcml2ZXJzL2Nsay9pbXgvY2xrLXNjdS5jCj4g PiA+IEBAIC0wLDAgKzEsMjY1IEBACj4gPiA+ICsvLyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjog R1BMLTIuMCsKPiA+ID4gKy8qCj4gPiA+ICsgKiBDb3B5cmlnaHQgMjAxOCBOWFAKPiA+ID4gKyAq ICAgRG9uZyBBaXNoZW5nIDxhaXNoZW5nLmRvbmdAbnhwLmNvbT4KPiA+ID4gKyAqLwo+ID4gPiAr Cj4gPiA+ICsjaW5jbHVkZSA8bGludXgvY2xrLXByb3ZpZGVyLmg+Cj4gPiA+ICsjaW5jbHVkZSA8 bGludXgvZXJyLmg+Cj4gPiA+ICsjaW5jbHVkZSA8bGludXgvc2xhYi5oPgo+ID4gPiArCj4gPiA+ ICsjaW5jbHVkZSAiY2xrLXNjdS5oIgo+ID4gPiArCj4gPiA+ICtzdHJ1Y3QgaW14X3NjX2lwYyAq Y2NtX2lwY19oYW5kbGU7ICAKPiA+IAo+ID4gV2h5IGRvZXMgdGhpcyBuZWVkIHRvIGJlIGEgZ2xv YmFsPyBDYW4gaXQgYmUgaW4gZWFjaCBjbGtfc2N1IGluc3RhbmNlIGluc3RlYWQ/Cj4gPiAgIAo+ IAo+IE5vLCBubyBuZWVkIHRvIGJlIGluIGVhY2ggY2xrX3NjdSBpbnN0YW5jZS4KPiBUaGVyZSdz IG9ubHkgb25lIGhhbmRsZXIuCj4gClNob3VsZG4ndCBpdCBiZSAnc3RhdGljJz8KCgpMb3RoYXIg V2HDn21hbm4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK