From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: linux-sctp@vger.kernel.org
Subject: Re: [PATCH] Fix error->errno typo
Date: Mon, 17 Dec 2018 11:38:21 +0000 [thread overview]
Message-ID: <20181217113821.GD9056@localhost.localdomain> (raw)
In-Reply-To: <20181217085615.12481-1-jijianwen@gmail.com>
On Mon, Dec 17, 2018 at 04:56:15PM +0800, Jianwen Ji wrote:
> Signed-off-by: Jianwen Ji <jijianwen@gmail.com>
> ---
> src/apps/sctp_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/apps/sctp_test.c b/src/apps/sctp_test.c
> index 4aa2d13..cd7654b 100644
> --- a/src/apps/sctp_test.c
> +++ b/src/apps/sctp_test.c
> @@ -870,7 +870,7 @@ int receive_r(int sk, int once)
> DEBUG_PRINT(DEBUG_MIN, "\trecvmsg(sk=%d) ", sk);
>
> error = recvmsg(recvsk, &inmessage, MSG_WAITALL);
> - if (error < 0 && error != EAGAIN) {
> + if (error < 0 && errno != EAGAIN) {
There is a similar one in sctp_status:
apps]$ git grep -B1 'error....E'
sctp_status.c- error = recvmsg(sk, &inmessage, MSG_WAITALL);
sctp_status.c: if (error < 0 && error != EAGAIN) {
--
sctp_test.c- error = recvmsg(recvsk, &inmessage, MSG_WAITALL);
sctp_test.c: if (error < 0 && error != EAGAIN) {
mind sending a patch fixing it too? Thanks.
> if (errno = ENOTCONN && socket_type = SOCK_STREAM &&
> role = SERVER) {
> printf("No association is present now!!\n");
> --
> 2.9.5
>
prev parent reply other threads:[~2018-12-17 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 8:56 [PATCH] Fix error->errno typo Jianwen Ji
2018-12-17 11:38 ` Marcelo Ricardo Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217113821.GD9056@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=linux-sctp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.