All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Michael Straube <straube.linux@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] staging: rtl8188eu: cleanup declarations in rtw_mlme_ext.c
Date: Mon, 17 Dec 2018 14:50:39 +0100	[thread overview]
Message-ID: <20181217135039.GA28400@kroah.com> (raw)
In-Reply-To: <20181215164616.2643-1-straube.linux@gmail.com>

On Sat, Dec 15, 2018 at 05:46:08PM +0100, Michael Straube wrote:
> Replace tabs with spaces and/or remove spaces in declarations.
> Remove unused/commented declarations, remove unnecessary comment,
> remove blank lines between declarations and add missing lines after
> declarations. Also clears some line over 80 characters checkpatch
> warnings.

That is a lot of different things to do all in one patch :(

Please break this up into "one logical thing per patch" please, so it
can be reviewed easier.

thanks,

greg k-h

      parent reply	other threads:[~2018-12-17 13:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-15 16:46 [PATCH 1/9] staging: rtl8188eu: cleanup declarations in rtw_mlme_ext.c Michael Straube
2018-12-15 16:46 ` [PATCH 2/9] staging: rtl8188eu: remove unnecessary parentheses " Michael Straube
2018-12-15 16:46 ` [PATCH 3/9] staging: rtl8188eu: remove unused arrays WFD_OUI and WMM_INFO_OUI Michael Straube
2018-12-15 16:46 ` [PATCH 4/9] staging: rtl8188eu: convert unsigned char arrays to u8 Michael Straube
2018-12-17 13:51   ` Greg KH
2018-12-15 16:46 ` [PATCH 5/9] staging: rtl8188eu: constify arrays in rtw_wlan_util.c Michael Straube
2018-12-15 16:46 ` [PATCH 6/9] staging: rtl8188eu: simplify null array initializations Michael Straube
2018-12-15 16:46 ` [PATCH 7/9] staging: rtl8188eu: change return type of is_basicrate() to bool Michael Straube
2018-12-15 16:46 ` [PATCH 8/9] staging: rtl8188eu: add spaces aroubd '&' in rtw_mlme_ext.c Michael Straube
2018-12-15 16:46 ` [PATCH 9/9] staging: rtl8188eu: cleanup brace coding style issues Michael Straube
2018-12-15 16:53 ` [PATCH 1/9] staging: rtl8188eu: cleanup declarations in rtw_mlme_ext.c Joe Perches
2018-12-16  7:59   ` Michael Straube
2018-12-17 13:50 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217135039.GA28400@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.