From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] tps65218.c: fix IRQ resource leak in tps65218_probe() Date: Mon, 17 Dec 2018 14:34:35 +0000 Message-ID: <20181217143435.GC4497@dell> References: <1544090279-26762-1-git-send-email-Christian.Hohnstaedt@wago.com> <20181214122559.GV4497@dell> <20181214122619.GW4497@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "J, KEERTHY" Cc: Christian Hohnstaedt , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org On Mon, 17 Dec 2018, J, KEERTHY wrote: > > > On 12/14/2018 5:56 PM, Lee Jones wrote: > > On Fri, 14 Dec 2018, Lee Jones wrote: > > > > > On Thu, 06 Dec 2018, Christian Hohnstaedt wrote: > > > > > > > Free allocated IRQ if reading the device ID fails. > > > > > > The patch is fine. However, in future please submit patches using the > > > format set (by precedent) by the subsystem. I will fix the subject > > > for you this time. > > > > > > To check the format, you can do: > > > > > > `git log --oneline -- ` > > > > Patch applied, by the way. > > This would no longer be needed as the bigger clean up is here: > > https://lkml.org/lkml/2018/12/9/86 > > As both are applied it results in a compilation issue. > > Lee Jones, > > Do you want me to submit a fix patch? Or you can revert this patch? > Anything fine by me. I have removed this patch from the MFD tree now. Thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog