Re: Need help fixing pop/click artifacts in an ASOC driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 945 bytes --]

On Mon, Dec 17, 2018 at 06:23:43PM +0200, Dimitris Papavasiliou wrote:
> On 12/17/18 5:40 PM, Mark Brown wrote:
> > That's why I was suggesting that you should be configuring the power
> > down time.

> I've already tried your suggestion, but unfortunately it doesn't
> work in the general case, as it doesn't help when the hw_params
> callback is called while the device is opened (but not playing).

The device being open shouldn't have any impact on the power state?

> > Unfortunately none of this helps.  Although the chip is turned
> > off without delay, it's turned off only while the device is
> > closed.  As soon as the device is opened, it is turned on and
> > kept on during all subsequent hw_params calls, where clock
> > switching takes place.  The pops always get through.

I would expect the stream to be closed and reopened by most applications
in between reconfigurations like that, it certainly used to be the
common pattern.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]