From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Jeff Moyer <jmoyer@redhat.com>,
Mike Snitzer <snitzer@redhat.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] blk-mq: skip zero-queue maps in blk_mq_map_swqueue
Date: Mon, 17 Dec 2018 18:30:34 +0100 [thread overview]
Message-ID: <20181217173034.GA13636@lst.de> (raw)
In-Reply-To: <20181217172856.14743-1-ming.lei@redhat.com>
On Tue, Dec 18, 2018 at 01:28:56AM +0800, Ming Lei wrote:
> >From 7e849dd9cf37 ("nvme-pci: don't share queue maps"), the mapping
> table won't be initialized actually if map->nr_queues is zero, so
> we can't use blk_mq_map_queue_type() to retrieve hctx any more.
>
> This way still may cause broken mapping, fix it by skipping zero-queues
> maps in blk_mq_map_swqueue().
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-12-17 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 17:28 [PATCH] blk-mq: skip zero-queue maps in blk_mq_map_swqueue Ming Lei
2018-12-17 17:30 ` Christoph Hellwig [this message]
2018-12-17 17:32 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217173034.GA13636@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.