Re: [Qemu-devel] [PATCH v1 0/4] de-macrofy softmmu

["Emilio G. Cota" <cota@braap.org>]

On Mon, Dec 17, 2018 at 16:15:10 +0000, Alex Bennée wrote:
> 
> Alex Bennée <alex.bennee@linaro.org> writes:
> 
> > Hi,
> >
> <snip>
> >
> > Unfortunately in my simple boot test I see a slight performance
> > degradation:
> >
> > original: 10 times (100.00%), avg time 5.358 (0.02 varience/0.13 deviation)
> > demacro: 10 times (100.00%), avg time 5.760 (0.08 varience/0.29 deviation)
> 
> Moving stuff back into cputlb seems to help:
> 
>  10 times (100.00%), avg time 5.583 (0.03 varience/0.17 deviation)

Yes, I'd move it there. Also playing with attr __noinline__
for the slow paths like we did for hardfloat should help.

> > Emilio,
> >
> > Any chance you could run this through your more comprehensive benchmark
> > suite?

Sure, please give me a few days (got a paper submission deadline
on Wed).

Do you have a branch I can pull from?

Thanks,

		Emilio