All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Chao Fan <fanc.fnst@cn.fujitsu.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org, bp@alien8.de,
	mingo@redhat.com, hpa@zytor.com, keescook@chromium.org,
	bhe@redhat.com, msys.mizuma@gmail.com,
	indou.takao@jp.fujitsu.com, caoj.fnst@cn.fujitsu.com
Subject: Re: [PATCH v14 1/5] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC
Date: Mon, 17 Dec 2018 19:48:00 +0100	[thread overview]
Message-ID: <20181217184800.GA60403@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1812171930280.1660@nanos.tec.linutronix.de>


* Thomas Gleixner <tglx@linutronix.de> wrote:

> On Mon, 17 Dec 2018, Ingo Molnar wrote:
> > * Chao Fan <fanc.fnst@cn.fujitsu.com> wrote:
> > > +		val[len] = '\0';
> > > +		return (acpi_physical_address)simple_strtoull(val, &e, 16);
> > 
> > 'return' is not a function - no need for the parenthesis.
> 
> It's a typecast which better has parenthesis....

Yeah, see my followup to the other reply where I withdraw the objection 
and point out the ugliness of the various typecasts.

Thanks,

	Ingo

  reply	other threads:[~2018-12-17 18:48 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14  9:30 [PATCH v14 0/5] x86/boot/KASLR: Parse ACPI table and limit KASLR to choosing immovable memory Chao Fan
2018-12-14  9:30 ` [PATCH v14 1/5] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC Chao Fan
2018-12-17 17:25   ` Ingo Molnar
2018-12-17 18:31     ` Thomas Gleixner
2018-12-17 18:48       ` Ingo Molnar [this message]
2018-12-18  1:27     ` Chao Fan
2018-12-18 11:28       ` Borislav Petkov
2018-12-19  1:18         ` Chao Fan
2018-12-14  9:30 ` [PATCH v14 2/5] x86/boot: Introduce efi_get_rsdp_addr() to find RSDP from EFI table Chao Fan
2018-12-17 17:30   ` Ingo Molnar
2018-12-17 17:36     ` Ingo Molnar
2018-12-25  7:43       ` Chao Fan
2018-12-17 18:32     ` Thomas Gleixner
2018-12-17 18:49       ` Ingo Molnar
2018-12-18  1:45     ` Chao Fan
2018-12-14  9:30 ` [PATCH v14 3/5] x86/boot: Introduce bios_get_rsdp_addr() to search RSDP in memory Chao Fan
2018-12-17 17:38   ` Ingo Molnar
2018-12-18  2:28     ` Chao Fan
2018-12-14  9:30 ` [PATCH v14 4/5] x86/boot: Parse SRAT address from RSDP and store immovable memory Chao Fan
2018-12-17 17:41   ` Ingo Molnar
2018-12-18  3:17     ` Chao Fan
2018-12-14  9:30 ` [PATCH v14 5/5] x86/boot/KASLR: Limit KASLR to extracting kernel in " Chao Fan
2018-12-17 17:43   ` Ingo Molnar
2018-12-18  2:49     ` Chao Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217184800.GA60403@gmail.com \
    --to=mingo@kernel.org \
    --cc=bhe@redhat.com \
    --cc=bp@alien8.de \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=fanc.fnst@cn.fujitsu.com \
    --cc=hpa@zytor.com \
    --cc=indou.takao@jp.fujitsu.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=msys.mizuma@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.