From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id F2E57E00C1E; Mon, 17 Dec 2018 11:26:09 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [198.47.23.249 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 10717E00BB7 for ; Mon, 17 Dec 2018 11:26:08 -0800 (PST) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id wBHJQ8D5115855; Mon, 17 Dec 2018 13:26:08 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1545074768; bh=mkTTTergRb2YRiVuhrio1cScAP+nRb+sLp6Gg2ILocM=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=aqhO3bZUEJeXCjas24SOkpblJKL2V1ksodDgIoJeMarylD9dAaq0rXoO3AlvqLdVs kGw0NQPNj4qnqfJYV7QfQwx+zOum62HW80UymTPGahFpgHCdd7qtyHNy1hzTICWZpi oSAnuSP3PuTP85r6hCgV9txmwU5y5l7mNTCHXO/M= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id wBHJQ8lG015110 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 17 Dec 2018 13:26:08 -0600 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 17 Dec 2018 13:26:07 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Mon, 17 Dec 2018 13:26:07 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id wBHJQ7Nh006833; Mon, 17 Dec 2018 13:26:07 -0600 Date: Mon, 17 Dec 2018 14:26:07 -0500 From: Denys Dmytriyenko To: Khem Raj Message-ID: <20181217192607.GC517@beryl> References: <20181209075901.18421-1-raj.khem@gmail.com> <20181217190708.GA517@beryl> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: meta-ti@yoctoproject.org Subject: Re: [PATCH V2] rwmem: Update to latest X-BeenThere: meta-ti@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-ti layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 19:26:10 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Mon, Dec 17, 2018 at 11:17:07AM -0800, Khem Raj wrote: > On Mon, Dec 17, 2018 at 11:07 AM Denys Dmytriyenko wrote: > > > > On Mon, Dec 17, 2018 at 10:58:47AM -0800, Khem Raj wrote: > > > ping^1 > > > > Yeah, I've been meaning to reply, just didn't have time. > > > > Mostly I'm fine with the update. But I don't like hidden submodules instead of > > direct dependencies. I already made pybind11 recipe for Tomi's kms++ some time > > ago (though upstreaming it to oe-core didn't work and I didn't find time to > > follow up). I haven't looked at "inih" module yet, but maybe should be a > > separate recipe as well? > > thats ok but usually if they are doing static linking its better to keep > the gitsubmods or maybe at best use multiple SRC_URIs for each > component, I think its just inviting more work to keep different > recipes in sync otherwise. These new recipes may interfere with other > packages > etc. Maybe it's more work, but it's more correct and more controlled environment, rather than letting components pull whatever dependencies they like... > > BTW, should it DEPENDS on python3 or inherit python3native? > > > > its needed during runtime. I thought the recommendation was to RDEPENDS on python3-core and/or specific modules, instead of pulling entire pythong3 into build dependencies. > > Denys > > > > > > > On Sat, Dec 8, 2018 at 11:59 PM Khem Raj wrote: > > > > > > > > New versions use CMake > > > > Correct detection of nm/ranlib/ar for LTO > > > > > > > > Signed-off-by: Khem Raj > > > > --- > > > > v2: Fix nm/ar/ranlib detection needed for LTO > > > > > > > > ...Make-provided-vars-for-ar-and-ranlib.patch | 34 +++++++++++++++++++ > > > > recipes-bsp/rwmem/rwmem_1.1.bb | 14 +++++--- > > > > 2 files changed, 44 insertions(+), 4 deletions(-) > > > > create mode 100644 recipes-bsp/rwmem/rwmem/0001-Use-CMake-provided-vars-for-ar-and-ranlib.patch > > > > > > > > diff --git a/recipes-bsp/rwmem/rwmem/0001-Use-CMake-provided-vars-for-ar-and-ranlib.patch b/recipes-bsp/rwmem/rwmem/0001-Use-CMake-provided-vars-for-ar-and-ranlib.patch > > > > new file mode 100644 > > > > index 00000000..d72f427d > > > > --- /dev/null > > > > +++ b/recipes-bsp/rwmem/rwmem/0001-Use-CMake-provided-vars-for-ar-and-ranlib.patch > > > > @@ -0,0 +1,34 @@ > > > > +From ee3bbdaae568118b4aad453c8fbb1ec648e8fbf2 Mon Sep 17 00:00:00 2001 > > > > +From: Khem Raj > > > > +Date: Sat, 8 Dec 2018 22:48:23 -0800 > > > > +Subject: [PATCH] Use CMake provided vars for ar and ranlib > > > > + > > > > +hardcoding them means we may not be able to cross compile the package > > > > +reliably as build host may or may not have gcc-ar and gcc-ranlib > > > > +installed, using the cross tools is the correct thing to do here > > > > + > > > > +Upstream-Status: Pending > > > > + > > > > +Signed-off-by: Khem Raj > > > > +--- > > > > + CMakeLists.txt | 4 ++-- > > > > + 1 file changed, 2 insertions(+), 2 deletions(-) > > > > + > > > > +diff --git a/CMakeLists.txt b/CMakeLists.txt > > > > +index 5e7f327..e36fca0 100644 > > > > +--- a/CMakeLists.txt > > > > ++++ b/CMakeLists.txt > > > > +@@ -50,8 +50,8 @@ if (NOT ${U_CMAKE_BUILD_TYPE} MATCHES DEBUG) > > > > + if (HAS_LTO_FLAG) > > > > + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -flto") > > > > + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -flto") > > > > +- set(CMAKE_AR gcc-ar) > > > > +- set(CMAKE_RANLIB gcc-ranlib) > > > > ++ set(CMAKE_AR ${CMAKE_CXX_COMPILER_AR}) > > > > ++ set(CMAKE_RANLIB ${CMAKE_CXX_COMPILER_RANLIB}) > > > > + endif() > > > > + endif() > > > > + > > > > +-- > > > > +2.19.2 > > > > + > > > > diff --git a/recipes-bsp/rwmem/rwmem_1.1.bb b/recipes-bsp/rwmem/rwmem_1.1.bb > > > > index 2848e1cd..62c33a3b 100644 > > > > --- a/recipes-bsp/rwmem/rwmem_1.1.bb > > > > +++ b/recipes-bsp/rwmem/rwmem_1.1.bb > > > > @@ -2,12 +2,18 @@ SUMMARY = "A small tool to read/write memory" > > > > LICENSE = "GPLv2+" > > > > LIC_FILES_CHKSUM = "file://LICENSE;md5=b234ee4d69f5fce4486a80fdaf4a4263" > > > > > > > > -SRCREV = "54904b8873b265d8f1faf82617c2f04814c102c6" > > > > -SRC_URI = "git://github.com/tomba/rwmem.git" > > > > +SRCREV = "ad00619005654f9cde5c2ea2ed2277d1d3ad2f26" > > > > +SRC_URI = "gitsm://github.com/tomba/rwmem.git \ > > > > + file://0001-Use-CMake-provided-vars-for-ar-and-ranlib.patch \ > > > > + " > > > > > > > > S = "${WORKDIR}/git" > > > > > > > > +inherit cmake pkgconfig > > > > + > > > > +DEPENDS += "python3" > > > > + > > > > do_install() { > > > > - install -d ${D}${bindir} > > > > - install -m 0755 rwmem ${D}${bindir} > > > > + install -D -m 0755 ${B}/bin/rwmem ${D}${bindir}/rwmem > > > > + install -D -m 0644 ${B}/lib/librwmem.a ${D}${libdir}/librwmem.a > > > > } > > > > -- > > > > 2.19.2 > > > > > > > -- > > > _______________________________________________ > > > meta-ti mailing list > > > meta-ti@yoctoproject.org > > > https://lists.yoctoproject.org/listinfo/meta-ti