From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Paasch <cpaasch@apple.com>
Subject: Re: [PATCH net-next 3/5] tcp: Print list of TFO-keys from proc
Date: Mon, 17 Dec 2018 15:35:05 -0800
Message-ID: <20181217233505.GC41383@MacBook-Pro-19.local>
References: <20181214224007.54813-1-cpaasch@apple.com>
 <20181214224007.54813-4-cpaasch@apple.com>
 <8080a54b-ddb2-03a7-d997-d5a091059bf4@gmail.com>
 <CAK6E8=cM3j9OMcOuhtCAcLp5A_KZkVKvwLaxfHVVCEzm5Zoomw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; CHARSET=US-ASCII
Content-Transfer-Encoding: 7BIT
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
        netdev <netdev@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        David Miller <davem@davemloft.net>
To: Yuchung Cheng <ycheng@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from ma1-aaemail-dr-lapp01.apple.com ([17.171.2.60]:54586 "EHLO
        ma1-aaemail-dr-lapp01.apple.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1726255AbeLQXfM (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 17 Dec 2018 18:35:12 -0500
Content-disposition: inline
In-reply-to: <CAK6E8=cM3j9OMcOuhtCAcLp5A_KZkVKvwLaxfHVVCEzm5Zoomw@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 17/12/18 - 08:52:22, Yuchung Cheng wrote:
> On Sun, Dec 16, 2018 at 10:32 PM Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >
> >
> >
> > On 12/14/2018 02:40 PM, Christoph Paasch wrote:
> > > Print the list of the TFO-keys with a comma separated. For setting the
> > > keys, we still only allow a single one to be set.
> > >
> >
> > I wonder if some applications expecting current format could break
> > after a formatting change.
> I have the same concern as well. print the extra keys in a different
> sysctl maybe? e.g. net.ipv4.tcp_fastopen_alt_keys

True, some apps might break on that.


Having a single place where all the keys are shown is still useful as that
way the key-rotation can simply check the current keys in one place.

I'm fine with adding net.ipv4.tcp_fastopen_key_list or something like that,
if we want to keep sysctl-API stable.


Christoph