All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: James Schulman <james.schulman@cirrus.com>
Cc: mark.rutland@arm.com, brian.austin@cirrus.com,
	alsa-devel@alsa-project.org, paul.handrigan@cirrus.com,
	lgirdwood@gmail.com, robh+dt@kernel.org
Subject: Re: [PATCH v3 2/2] ASoC: cs35l36: Add device tree documentation for CS35L36
Date: Tue, 18 Dec 2018 09:30:22 +0000	[thread overview]
Message-ID: <20181218093022.GT16508@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <1545072932-18474-2-git-send-email-james.schulman@cirrus.com>

On Mon, Dec 17, 2018 at 12:55:32PM -0600, James Schulman wrote:
> +  - cirrus,irq-polarity : Selects the polarity of the selected interrupt output
> +  when in push-pull mode. Note - when the selected interrupt output is in
> +  open-drain mode, INT_POL_SEL must be set to 0.
> +
> +  0 = Active-low (Default)
> +  1 = Active-high
> +

Only outstanding comment from me is this guy I think. Is there a
reason you prefer not to specify it through the interrupt flags?

Thanks,
Charles

  reply	other threads:[~2018-12-18  9:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 18:55 [PATCH v3 1/2] ASoC: cs35l36: Add support for Cirrus CS35L36 Amplifier James Schulman
2018-12-17 18:55 ` [PATCH v3 2/2] ASoC: cs35l36: Add device tree documentation for CS35L36 James Schulman
2018-12-18  9:30   ` Charles Keepax [this message]
2018-12-20 19:39     ` Schulman, James
2018-12-18 15:26 ` [PATCH v3 1/2] ASoC: cs35l36: Add support for Cirrus CS35L36 Amplifier kbuild test robot
2018-12-18 15:26 ` [PATCH] ASoC: cs35l36: fix returnvar.cocci warnings kbuild test robot
  -- strict thread matches above, loose matches on Subject: below --
2019-02-07 18:12 [PATCH v3 2/2] ASoC: cs35l36: Add device tree documentation for CS35L36 James Schulman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181218093022.GT16508@imbe.wolfsonmicro.main \
    --to=ckeepax@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=brian.austin@cirrus.com \
    --cc=james.schulman@cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=paul.handrigan@cirrus.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.