From: Peter Zijlstra <peterz@infradead.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>,
lizefan@huawei.com, Johannes Weiner <hannes@cmpxchg.org>,
axboe@kernel.dk, dennis@kernel.org,
Dennis Zhou <dennisszhou@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
cgroups@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
kernel-team@android.com
Subject: Re: [PATCH 4/6] psi: introduce state_mask to represent stalled psi states
Date: Tue, 18 Dec 2018 11:17:27 +0100 [thread overview]
Message-ID: <20181218101727.GA15430@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJuCfpHrQB7OtEC535=s4iJqwan17nAc-mbycV1aJ3RUQTWCPA@mail.gmail.com>
On Mon, Dec 17, 2018 at 05:14:53PM -0800, Suren Baghdasaryan wrote:
> On Mon, Dec 17, 2018 at 7:55 AM Peter Zijlstra <peterz@infradead.org> wrote:
> > > + if (state_mask & (1 << s))
> >
> > We have the BIT() macro, but I'm honestly not sure that will improve
> > things.
>
> I was mimicking the rest of the code in psi.c that uses this kind of
> bit masking. Can change if you think that would be better.
Yeah, I really don't know.. keep it as is I suppose.
next prev parent reply other threads:[~2018-12-18 10:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 17:15 [PATCH 0/6] psi: pressure stall monitors Suren Baghdasaryan
2018-12-14 17:15 ` [PATCH 1/6] fs: kernfs: add poll file operation Suren Baghdasaryan
2018-12-14 17:15 ` [PATCH 2/6] kernel: cgroup: " Suren Baghdasaryan
2018-12-14 17:15 ` [PATCH 3/6] psi: eliminate lazy clock mode Suren Baghdasaryan
2018-12-17 14:57 ` Peter Zijlstra
2018-12-18 1:10 ` Suren Baghdasaryan
2018-12-14 17:15 ` [PATCH 4/6] psi: introduce state_mask to represent stalled psi states Suren Baghdasaryan
2018-12-17 15:55 ` Peter Zijlstra
2018-12-18 1:14 ` Suren Baghdasaryan
2018-12-18 10:17 ` Peter Zijlstra [this message]
2018-12-14 17:15 ` [PATCH 5/6] psi: rename psi fields in preparation for psi trigger addition Suren Baghdasaryan
2018-12-14 17:15 ` [PATCH 6/6] psi: introduce psi monitor Suren Baghdasaryan
2018-12-17 16:22 ` Peter Zijlstra
2018-12-18 1:21 ` Suren Baghdasaryan
2018-12-18 10:46 ` Peter Zijlstra
2018-12-18 11:20 ` Peter Zijlstra
2018-12-18 17:30 ` Johannes Weiner
2018-12-18 17:58 ` Suren Baghdasaryan
2018-12-18 19:18 ` Joel Fernandes
2018-12-18 20:29 ` Suren Baghdasaryan
2018-12-17 16:27 ` Peter Zijlstra
2018-12-18 1:22 ` Suren Baghdasaryan
2018-12-18 16:51 ` kbuild test robot
2018-12-18 16:51 ` kbuild test robot
2018-12-22 14:12 ` kbuild test robot
2018-12-22 14:12 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218101727.GA15430@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dennis@kernel.org \
--cc=dennisszhou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.