From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: mazziesaccount@gmail.com, Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
ldewangan@nvidia.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regmap: regmap-irq: Remove default irq type setting from core
Date: Tue, 18 Dec 2018 15:15:01 +0200 [thread overview]
Message-ID: <20181218131501.GF2477@localhost.localdomain> (raw)
In-Reply-To: <CAMRc=MexeOcqNgMr1Vq=T1NTeizP20fj3vx3EwxQNv20Cc6bAw@mail.gmail.com>
On Tue, Dec 18, 2018 at 02:08:41PM +0100, Bartosz Golaszewski wrote:
> wt., 18 gru 2018 o 11:58 Matti Vaittinen
> <matti.vaittinen@fi.rohmeurope.com> napisał(a):
> >
> > The common code should not set IRQ type. Read HW defaults to the
> > cache at startup instead of forcing type to EDGE_BOTH. If
> > default setting is needed this should be done via normal
> > mechanisms or by chip specific code if normal mechanisms are not
> > suitable for some reason. Common regmap-irq code should not have
> > defaults hard-coded but keep the HW/boot defaults untouched.
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> > I was not able to test this change as I have no max77620 which seems to
> > be the only user of regmap-irq type-setting in tree as of now.
> >
>
> Works with my work-in-progress max77650 driver that uses the new
> type_in_mask flag.
>
> Tested-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Thanks a bunch for testing Bartosz :) Highly appreciated!
--
Matti Vaittinen
ROHM Semiconductors
~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
prev parent reply other threads:[~2018-12-18 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 10:58 [PATCH] regmap: regmap-irq: Remove default irq type setting from core Matti Vaittinen
2018-12-18 13:08 ` Bartosz Golaszewski
2018-12-18 13:15 ` Matti Vaittinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218131501.GF2477@localhost.localdomain \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.