From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A588C43387 for ; Tue, 18 Dec 2018 16:29:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00EF321873 for ; Tue, 18 Dec 2018 16:29:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726840AbeLRQ32 (ORCPT ); Tue, 18 Dec 2018 11:29:28 -0500 Received: from verein.lst.de ([213.95.11.211]:41742 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726798AbeLRQ32 (ORCPT ); Tue, 18 Dec 2018 11:29:28 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 0C3EA68D8D; Tue, 18 Dec 2018 17:29:26 +0100 (CET) Date: Tue, 18 Dec 2018 17:29:26 +0100 From: Christoph Hellwig To: Hannes Reinecke Cc: Christoph Hellwig , "Martin K. Petersen" , Jens Axboe , Ming Lei , Paul Mackerras , Juergen Gross , linux-scsi@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: remove the "clustering" flag V2 Message-ID: <20181218162926.GA12474@lst.de> References: <20181213151710.30036-1-hch@lst.de> <20181218070826.GA1787@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Dec 18, 2018 at 08:47:48AM +0100, Hannes Reinecke wrote: > On 12/18/18 8:08 AM, Christoph Hellwig wrote: >> Martin and others: >> >> can we get this reviewed and merge before the end of the merge window? >> That gets the clustering put of the way for the multipage-biovec work >> from Ming which we want to land in the block tree early in the next >> merge window. >> > Have we reviewed the crash in iscsi target? > It might be something completely different, but the fact still stands that > the bug is exposed after removing the clustering flag... There is no change in behavior for the drivers, it just uses a different know to archive the same thing. The crashes in the iSCSI target are if we remove the nob entirely on the initiator, but that is not what this series does.