From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathan Chancellor Subject: Re: [PATCH] drm/i915: Disable -Wuninitialized for intel_breadcrumbs.o Date: Tue, 18 Dec 2018 12:01:43 -0700 Message-ID: <20181218190143.GA7036@flashbox> References: <20181025193601.11746-1-natechancellor@gmail.com> <154513398652.1108.7150969916024071452@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <154513398652.1108.7150969916024071452@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Nick Desaulniers , LKML , dri-devel@lists.freedesktop.org, Matthias Kaehlcke , rodrigo.vivi@intel.com List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBEZWMgMTgsIDIwMTggYXQgMTE6NTM6MDZBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgTmljayBEZXNhdWxuaWVycyAoMjAxOC0xMC0yNSAyMzoyMDo1OCkKPiA+ IE9uIFRodSwgT2N0IDI1LCAyMDE4IGF0IDEyOjM2IFBNIE5hdGhhbiBDaGFuY2VsbG9yCj4gPiA8 bmF0ZWNoYW5jZWxsb3JAZ21haWwuY29tPiB3cm90ZToKPiA+ID4KPiA+ID4gVGhpcyB3YXJuaW5n IGlzIGRpc2FibGVkIGJ5IGRlZmF1bHQgaW4gc2NyaXB0cy9NYWtlZmlsZS5leHRyYXdhcm4gd2hl bgo+ID4gPiBXPSBpcyBub3QgcHJvdmlkZWQgYnV0IHRoaXMgTWFrZWZpbGUgYWRkcyAtV2FsbCBh ZnRlciB0aGlzIHdhcm5pbmcgaXMKPiA+ID4gZGlzYWJsZWQgc28gaXQgc2hvd3MgdXAgaW4gdGhl IGJ1aWxkIHdoZW4gaXQgc2hvdWxkbid0Ogo+ID4gPgo+ID4gPiBJbiBmaWxlIGluY2x1ZGVkIGZy b20gZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYzo4OTU6Cj4gPiA+IGRy aXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pbnRlbF9icmVhZGNydW1icy5jOjM1MDozNDog ZXJyb3I6Cj4gPiA+IHZhcmlhYmxlICd3cScgaXMgdW5pbml0aWFsaXplZCB3aGVuIHVzZWQgd2l0 aGluIGl0cyBvd24gaW5pdGlhbGl6YXRpb24KPiA+ID4gWy1XZXJyb3IsLVd1bmluaXRpYWxpemVk XQo+ID4gPiAgICAgICAgIERFQ0xBUkVfV0FJVF9RVUVVRV9IRUFEX09OU1RBQ0sod3EpOwo+ID4g PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn4KPiA+ID4gLi9pbmNs dWRlL2xpbnV4L3dhaXQuaDo3NDo2Mzogbm90ZTogZXhwYW5kZWQgZnJvbSBtYWNybwo+ID4gPiAn REVDTEFSRV9XQUlUX1FVRVVFX0hFQURfT05TVEFDSycKPiA+ID4gICAgICAgICBzdHJ1Y3Qgd2Fp dF9xdWV1ZV9oZWFkIG5hbWUgPSBfX1dBSVRfUVVFVUVfSEVBRF9JTklUX09OU1RBQ0sobmFtZSkK PiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH5+fn4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgXn5+fgo+ID4gPiAuL2luY2x1ZGUvbGludXgvd2FpdC5oOjcyOjMz OiBub3RlOiBleHBhbmRlZCBmcm9tIG1hY3JvCj4gPiA+ICdfX1dBSVRfUVVFVUVfSEVBRF9JTklU X09OU1RBQ0snCj4gPiA+ICAgICAgICAgKHsgaW5pdF93YWl0cXVldWVfaGVhZCgmbmFtZSk7IG5h bWU7IH0pCj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+fn4K PiA+ID4gMSBlcnJvciBnZW5lcmF0ZWQuCj4gPiA+Cj4gPiA+IFRoaXMgd2FybmluZyBsb29rcyB0 byBiZSBhIGZhbHNlIHBvc2l0aXZlIGdpdmVuIHRoYXQgaW5pdF93YWl0cXVldWVfaGVhZAo+ID4g PiBpbml0aWFsaXplcyBuYW1lIGJlZm9yZSBpdCBpcyB1c2VkLiBSYXRoZXIgdGhhbiBkaXNhYmxl IHRoZSB3YXJuaW5nIGZvcgo+ID4gPiB0aGUgZnVsbCBmb2xkZXIgbGlrZSBjb21taXQgNDZlMjA2 ODA4MWU5ICgiZHJtL2k5MTU6IERpc2FibGUgc29tZSBleHRyYQo+ID4gCj4gPiBjYyBhdXRob3Iv cmV2aWV3ZXIgb2YgNDZlMjA2ODA4MWU5Lgo+ID4gCj4gPiBJJ20gZmluZSB3aXRoIHRoZSBwYXRj aCBhcyBpcywgdW5sZXNzIG90aGVycyBwcmVmZXIgdG8gZGlzYWJsZSBpdCBmb3IKPiA+IHRoZSB3 aG9sZSBzdWJkaXI/ICBXZSBjb3VsZCBiZSBwbGF5aW5nIHdoYWNrLWEtbW9sZSBpbiB0aGUgZnV0 dXJlCj4gPiBkaXNhYmxpbmcgdGhpcyB3YXJuaW5nIGZvciBvdGhlciB0cmFuc2xhdGlvbiB1bml0 cy4KPiAKCkhpIENocmlzLAoKPiBZZXMsIGV4YWN0bHkgdGhpcyBzaW5jZSB0aGUgd2FybmluZyBp cyBnZW5lcmF0ZWQgYnkgYSBjb3JlIGhlYWRlciBhbmQgYQo+IGZhaXJseSBjb21tb24gcGF0dGVy biBpdHMgdXNlIGlzIG5vdCByZXN0cmljdGVkIHRvIGFueSBzaW5nbGUgZmlsZS4KPiAoV2lsbCBu b3QgYWxsIHNlbGZ0ZXN0cyBzaW1pbGFybHkgZXhwbG9kZT8pCj4gCgpXZWxsLCAtV3VuaW5pdGlh bGl6ZWQgaXMgdHVybmVkIG9mZiBmb3IgdGhlIHdob2xlIGtlcm5lbCB1bmxlc3MgVz0gaXMKcGFz c2VkLiBTbyBJIHN1cHBvc2UgaXQgc2hvdWxkIGJlIHR1cm5lZCBiYWNrIG9uIGZvciB0aGUgd2hv bGUgZm9sZGVyCmJ1dCBJIG5vdGljZWQgdGhhdCB0aGUgaTkxNSBNYWtlZmlsZSBwdXJwb3NlZnVs bHkgdHVybnMgYWxsIG9mIHRoZQpkaXNhYmxlZCB3YXJuaW5ncyBiYWNrIG9uIGZvciBoZWF2aWVy IGNvdmVyYWdlIHNvIGl0IG1ha2VzIHNvbWUgc2Vuc2UgdG8KanVzdCBsZWF2ZSBpdCBvZmYgZm9y IG9uZSB0cmFuc2xhdGlvbiB1bml0IHdoZW4gaXQncyBqdXN0IG9uZQp0cmFuc2xhdGlvbiB1bml0 IHRoYXQgaGFzIHRoZSBwcm9ibGVtLiBUaGF0IHNhaWQsIEknbSBtb3JlIHRoYW4gaGFwcHkgdG8K c2VuZCBhIHYyIHR1cm5pbmcgaXQgb2ZmIGZvciB0aGUgd2hvbGUgZm9sZGVyIGlmIHlvdSB0aGlu ayB0aGF0IGJlc3QuCgo+IFRoZSBvdGhlciBmYWxzZS1wb3NpdGl2ZSBjbGFuZy02IGdhdmUgd2Fz IGZvciBsb2NhbF9jbG9ja191cygpLgo+IFByZXN1bWFibHkgdGhhdCBvbmUgaXMgZml4ZWQ/Cj4g LUNocmlzCgpXaXRoIHRoaXMgcGF0Y2gsIEkgY2FuIGJ1aWxkIGk5MTUgdXNpbmcgZGVmY29uZmln IGFuZCBhbGx5ZXNjb25maWcKd2l0aG91dCBhbnkgd2FybmluZ3Mgd2l0aCB0aXAtb2YtdHJlZSBD bGFuZy4KClRoYW5rIHlvdSBmb3IgdGhlIGNvbW1lbnRzIQpOYXRoYW4KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76175C43387 for ; Tue, 18 Dec 2018 19:01:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40C2421873 for ; Tue, 18 Dec 2018 19:01:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L4CND8zf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726746AbeLRTBt (ORCPT ); Tue, 18 Dec 2018 14:01:49 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:34052 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726536AbeLRTBs (ORCPT ); Tue, 18 Dec 2018 14:01:48 -0500 Received: by mail-ed1-f67.google.com with SMTP id b3so14824269ede.1 for ; Tue, 18 Dec 2018 11:01:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aVvKRasEcMJmG+26dfvEoDyzu5fKSKEiXYvCB/g791I=; b=L4CND8zfnNTXlCi1HRwbGJwObKwEN02g3AUN1VYsskQmYZRklYse8GZGCvZk3MTOAA acZoUDH5KBZYAlqeGny0bpKgprzRMf37n+Nv/gxGqkw0XVIyGxA4nF7BDzcQW3OZEStZ dmvUVzrj0Mdcy6swf5PEhVZ5z626Qw5IXJZPdESr3rcUUORVoJwfVOPJyS5gRChyRWtD 4H6SPhYwshKaygHwHnAqe1DxhfDsPObI9mJ3GULifY2OdOghxZbz9J3lmQZz344wnsTv mc0vZxWOKbfMT2kmBxPLZMQEWLLZQaW0WxkvfswBzOZtL1R6vjEonaFvAxAhoIw5P5V1 HNDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aVvKRasEcMJmG+26dfvEoDyzu5fKSKEiXYvCB/g791I=; b=f3Pl/0W63cV5+x2YBStwGXgpBJJoG4KVrkc9B5tpr1LFlXDDLBX7VsxijX9NjZlZNO 6onZw85aWDcuA5c6veKIvupbSIiB/IvEdYxShkkuTD+HN82idHnAYUryvWobbJEHBbNJ WgJwdYUUdDVI3aAlL+PD4y1fP0/xpKjiuEP0oI1/nyKX3KLjlXczPsp/GZdFGZq9p+9H /GPRkaZCymNZeUuuYgwth+/6aWrsGq6pHEAcCTZmCiv3EBZBKe96BRBuryj3FdsS2AW3 Fomr8Wg2BQKp4I3ErKfqoCcMYRYqO2O6gjARERK8rHDrpcTrd5OGZQSlmq5I30QdqOHt NzsA== X-Gm-Message-State: AA+aEWZsViDm+ullnlbbfhHNa//J/4aq0k4MUlzBQ/a00lGq3Kg5yucN 4c02vFf3uHKbH14D7hraft4= X-Google-Smtp-Source: AFSGD/U7ldUetxxDudPvfiKIvumgfryQoKY6n0XM+XkECmX0d9Cijcvlx6xJ7KTx8CULT4uFglqAlQ== X-Received: by 2002:aa7:c0d0:: with SMTP id j16mr16956465edp.173.1545159706533; Tue, 18 Dec 2018 11:01:46 -0800 (PST) Received: from flashbox ([2a01:4f8:10b:24a5::2]) by smtp.gmail.com with ESMTPSA id p36sm4844960edc.78.2018.12.18.11.01.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Dec 2018 11:01:45 -0800 (PST) Date: Tue, 18 Dec 2018 12:01:43 -0700 From: Nathan Chancellor To: Chris Wilson Cc: Nick Desaulniers , jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, LKML , Matthias Kaehlcke Subject: Re: [PATCH] drm/i915: Disable -Wuninitialized for intel_breadcrumbs.o Message-ID: <20181218190143.GA7036@flashbox> References: <20181025193601.11746-1-natechancellor@gmail.com> <154513398652.1108.7150969916024071452@skylake-alporthouse-com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <154513398652.1108.7150969916024071452@skylake-alporthouse-com> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 18, 2018 at 11:53:06AM +0000, Chris Wilson wrote: > Quoting Nick Desaulniers (2018-10-25 23:20:58) > > On Thu, Oct 25, 2018 at 12:36 PM Nathan Chancellor > > wrote: > > > > > > This warning is disabled by default in scripts/Makefile.extrawarn when > > > W= is not provided but this Makefile adds -Wall after this warning is > > > disabled so it shows up in the build when it shouldn't: > > > > > > In file included from drivers/gpu/drm/i915/intel_breadcrumbs.c:895: > > > drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c:350:34: error: > > > variable 'wq' is uninitialized when used within its own initialization > > > [-Werror,-Wuninitialized] > > > DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wq); > > > ^~ > > > ./include/linux/wait.h:74:63: note: expanded from macro > > > 'DECLARE_WAIT_QUEUE_HEAD_ONSTACK' > > > struct wait_queue_head name = __WAIT_QUEUE_HEAD_INIT_ONSTACK(name) > > > ~~~~ ^~~~ > > > ./include/linux/wait.h:72:33: note: expanded from macro > > > '__WAIT_QUEUE_HEAD_INIT_ONSTACK' > > > ({ init_waitqueue_head(&name); name; }) > > > ^~~~ > > > 1 error generated. > > > > > > This warning looks to be a false positive given that init_waitqueue_head > > > initializes name before it is used. Rather than disable the warning for > > > the full folder like commit 46e2068081e9 ("drm/i915: Disable some extra > > > > cc author/reviewer of 46e2068081e9. > > > > I'm fine with the patch as is, unless others prefer to disable it for > > the whole subdir? We could be playing whack-a-mole in the future > > disabling this warning for other translation units. > Hi Chris, > Yes, exactly this since the warning is generated by a core header and a > fairly common pattern its use is not restricted to any single file. > (Will not all selftests similarly explode?) > Well, -Wuninitialized is turned off for the whole kernel unless W= is passed. So I suppose it should be turned back on for the whole folder but I noticed that the i915 Makefile purposefully turns all of the disabled warnings back on for heavier coverage so it makes some sense to just leave it off for one translation unit when it's just one translation unit that has the problem. That said, I'm more than happy to send a v2 turning it off for the whole folder if you think that best. > The other false-positive clang-6 gave was for local_clock_us(). > Presumably that one is fixed? > -Chris With this patch, I can build i915 using defconfig and allyesconfig without any warnings with tip-of-tree Clang. Thank you for the comments! Nathan