From: Andi Kleen <ak@linux.intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: "Li, Aubrey" <aubrey.li@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Aubrey Li <aubrey.li@intel.com>,
mingo@redhat.com, peterz@infradead.org, hpa@zytor.com,
tim.c.chen@linux.intel.com, arjan@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/3] x86/fpu: track AVX-512 usage of tasks
Date: Tue, 18 Dec 2018 14:05:37 -0800 [thread overview]
Message-ID: <20181218220537.GJ25620@tassilo.jf.intel.com> (raw)
In-Reply-To: <d892d7bb-2a66-497c-4728-138c8e5e077f@intel.com>
On Tue, Dec 18, 2018 at 01:44:41PM -0800, Dave Hansen wrote:
> On 12/18/18 1:38 PM, Andi Kleen wrote:
> >> I misunderstood, you mean 32bit kernel, not 32bit machine. Theoretically 32bit
> >> kernel can use AVX512, but not sure if anyone use it like this. get_jiffies_64()
> >> includes jiffies_lock ops so not good in context switch. So I want to use raw
> >> jiffies_64 here. jiffies is a good candidate but it has wraparound overflow issue.
> >> Other time source are expensive here.
> >>
> >> Should I limit the code only running on 64bit kernel?
> > Yes making it 64bit only should be fine.
>
> I think I'd rather just disable AVX512 itself on 32-bit and be done with
> it. I think more than half of the ~2k of XSAVE space that it consumes
> in *every* *task* is just pure waste because it has to be 0's.
>
> This ~2k of extra space is also lowmem, which makes it even more valuable.
That will actually break programs.
If someone compiled binaries with -march=native on a system with AVX512
they wouldn't work anymore.
Don't think we can do it.
-Andi
next prev parent reply other threads:[~2018-12-18 22:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 4:22 [PATCH v6 1/3] x86/fpu: track AVX-512 usage of tasks Aubrey Li
2018-12-18 4:22 ` [PATCH v6 2/3] proc: add AVX-512 usage elapsed time to /proc/pid/status Aubrey Li
2018-12-18 4:22 ` [PATCH v6 3/3] Documentation/filesystems/proc.txt: add AVX512_elapsed_ms Aubrey Li
2018-12-18 14:14 ` [PATCH v6 1/3] x86/fpu: track AVX-512 usage of tasks Thomas Gleixner
2018-12-18 15:11 ` Li, Aubrey
2018-12-18 15:32 ` Thomas Gleixner
2018-12-18 16:28 ` Li, Aubrey
2018-12-18 21:38 ` Andi Kleen
2018-12-18 21:44 ` Dave Hansen
2018-12-18 22:05 ` Andi Kleen [this message]
2018-12-19 0:26 ` Li, Aubrey
2018-12-19 9:45 ` Thomas Gleixner
2018-12-18 17:14 ` Dave Hansen
2018-12-18 23:23 ` Li, Aubrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218220537.GJ25620@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=aubrey.li@intel.com \
--cc=aubrey.li@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.