From: Andi Kleen <ak@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Martin Jambor <mjambor@suse.cz>, Miroslav Benes <mbenes@suse.cz>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: objtool warnings for kernel/trace/trace_selftest_dynamic.o
Date: Tue, 18 Dec 2018 14:13:38 -0800 [thread overview]
Message-ID: <20181218221338.GK25620@tassilo.jf.intel.com> (raw)
In-Reply-To: <20181218165713.4309797a@gandalf.local.home>
On Tue, Dec 18, 2018 at 04:57:13PM -0500, Steven Rostedt wrote:
> Hmm, how does that work? When does LTO do its linker magic? Because the
> fentry/mcounts are added when the object is created. Are they removed
> if the compiler sees that it can be inlined? Or does LTO just compile
> everything in one go?
LTO compiles everything in one go at link time. The objects
just contain immediate code.
Also in principle it should track command line options from the command
line and apply them by function, but there were bugs regarding
this in older gcc versions so it may not always work.
> Again, that's not the ftrace case. It doesn't care about more than one
> out of line instance. Thus, for this particular use, "used" should be
> good enough.
You mean noinline used?
Inlining would certainly break the test.
-Andi
next prev parent reply other threads:[~2018-12-18 22:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 18:33 objtool warnings for kernel/trace/trace_selftest_dynamic.o Arnd Bergmann
2018-12-17 17:39 ` Josh Poimboeuf
2018-12-17 18:04 ` Andi Kleen
2018-12-17 18:16 ` Josh Poimboeuf
2018-12-17 19:29 ` Peter Zijlstra
2018-12-17 20:55 ` Andi Kleen
2018-12-17 22:35 ` Peter Zijlstra
2018-12-17 23:59 ` Andi Kleen
2018-12-18 9:19 ` Peter Zijlstra
2018-12-18 21:22 ` Andi Kleen
2018-12-17 21:31 ` Josh Poimboeuf
2018-12-17 22:36 ` Steven Rostedt
2018-12-18 0:06 ` Andi Kleen
2018-12-18 2:49 ` Josh Poimboeuf
2018-12-18 4:22 ` Andi Kleen
2018-12-18 9:28 ` Miroslav Benes
2018-12-18 12:15 ` Martin Jambor
2018-12-18 12:31 ` Steven Rostedt
2018-12-18 14:01 ` Josh Poimboeuf
2018-12-18 21:20 ` Andi Kleen
2018-12-19 3:44 ` Sean Christopherson
2018-12-19 17:31 ` Martin Jambor
2018-12-18 21:15 ` Andi Kleen
2018-12-18 21:57 ` Steven Rostedt
2018-12-18 22:13 ` Andi Kleen [this message]
2018-12-18 22:16 ` Steven Rostedt
2018-12-18 23:26 ` Andi Kleen
2018-12-18 23:40 ` Steven Rostedt
2018-12-19 17:38 ` Martin Jambor
2018-12-18 3:05 ` Josh Poimboeuf
2018-12-17 23:54 ` Andi Kleen
2018-12-17 21:03 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218221338.GK25620@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=arnd@arndb.de \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mjambor@suse.cz \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.